From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 227A436D for ; Mon, 30 Jun 2014 12:19:10 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 30 Jun 2014 03:19:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,574,1400050800"; d="scan'208";a="562931640" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga002.fm.intel.com with ESMTP; 30 Jun 2014 03:19:28 -0700 Received: from irsmsx105.ger.corp.intel.com (163.33.3.28) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.123.3; Mon, 30 Jun 2014 11:19:28 +0100 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.62]) by IRSMSX105.ger.corp.intel.com ([169.254.7.76]) with mapi id 14.03.0123.003; Mon, 30 Jun 2014 11:19:28 +0100 From: "De Lara Guarch, Pablo" To: Thomas Monjalon , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] app/test: fix build switches to enable cmdline tests Thread-Index: AQHPkezYPDW4+iO6f0e0y9dS9ZJAFpuEvICQgAS3wtA= Date: Mon, 30 Jun 2014 10:19:26 +0000 Message-ID: References: <1403862406-31698-1-git-send-email-thomas.monjalon@6wind.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/test: fix build switches to enable cmdline tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jun 2014 10:19:11 -0000 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > > Sent: Friday, June 27, 2014 10:47 AM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH] app/test: fix build switches to enable cmdl= ine > > tests > > > > There were 2 typos since these commits (in 1.6.0 releases): > > 21a7f4e264 fix build without librte_cmdline > > cac6d08c8b replace --use-device option by --pci-whitelist and --vdev > > In makefiles, the build options are prefixed with CONFIG_RTE_ > > but in .c file, it is only RTE_. > > > > These typos were disabling cmdline unit tests and test of "--vdev eth_r= ing" > > option. > > > > Signed-off-by: Thomas Monjalon > > --- >=20 > Acked-by: Pablo de Lara Actually, I am thinking of removing the vdev eth_ring test. It doesn't work= , as a secondary process cannot allocate memzone, if I am not wrong, so it cannot create an the ethd= ev. Any objections on this? Thanks, Pablo