From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by dpdk.org (Postfix) with ESMTP id E1E7D333 for ; Tue, 1 Jul 2014 13:44:38 +0200 (CEST) Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga101.ch.intel.com with ESMTP; 01 Jul 2014 04:44:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,581,1400050800"; d="scan'208";a="452035693" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by azsmga001.ch.intel.com with ESMTP; 01 Jul 2014 04:44:51 -0700 Received: from irsmsx153.ger.corp.intel.com (163.33.192.75) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.123.3; Tue, 1 Jul 2014 12:44:50 +0100 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.62]) by IRSMSX153.ger.corp.intel.com ([169.254.9.233]) with mapi id 14.03.0123.003; Tue, 1 Jul 2014 12:44:50 +0100 From: "De Lara Guarch, Pablo" To: Olivier Matz , "dev@dpdk.org" Thread-Topic: [PATCH v2] app/test: fix vdev test in test_eal_flags Thread-Index: AQHPlQ4CNHuEqpi50kOIaMVN3HUcw5uLGQpw Date: Tue, 1 Jul 2014 11:44:49 +0000 Message-ID: References: <53B27D70.4090102@6wind.com> <1404206489-30703-1-git-send-email-olivier.matz@6wind.com> In-Reply-To: <1404206489-30703-1-git-send-email-olivier.matz@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] app/test: fix vdev test in test_eal_flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jul 2014 11:44:39 -0000 Hi Olivier, > -----Original Message----- > From: Olivier Matz [mailto:olivier.matz@6wind.com] > Sent: Tuesday, July 01, 2014 10:21 AM > To: dev@dpdk.org; De Lara Guarch, Pablo > Cc: olivier.matz@6wind.com > Subject: [PATCH v2] app/test: fix vdev test in test_eal_flags >=20 > In whitelist test, within EAL flags unit test, the vdev flag test fails > because it is started in a secondary process, which is not able to > allocate memzones and this is required to instanciate a pmd_ring. >=20 > This patch changes the vdev flag test to run it in a primary process. >=20 > Patch "app/test: fix build switches to enable cmdline tests" > from Thomas Monjalon is needed for this patch. >=20 > Signed-off-by: Olivier Matz > --- > app/test/test_eal_flags.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c > index 1b80b80..4a50d37 100644 > --- a/app/test/test_eal_flags.c > +++ b/app/test/test_eal_flags.c > @@ -59,6 +59,7 @@ > #define no_shconf "--no-shconf" > #define pci_whitelist "--pci-whitelist" > #define vdev "--vdev" > +#define whitelist_prefix "whitelist" > #define memtest "memtest" > #define memtest1 "memtest1" > #define memtest2 "memtest2" > @@ -314,7 +315,8 @@ test_whitelist_flag(void) > pci_whitelist, "00FF:09:0B.3"}; > const char *wlval2[] =3D {prgname, prefix, mp_flag, "-n", "1", "-c", "1= ", > pci_whitelist, "09:0B.3", pci_whitelist, "0a:0b.1"}; > - const char *wlval3[] =3D {prgname, prefix, mp_flag, "-n", "1", "-c", "1= ", > + const char *wlval3[] =3D {prgname, "--file-prefix=3D" whitelist_prefix, > + "-n", "1", "-c", "1", > pci_whitelist, "09:0B.3,type=3Dtest", > pci_whitelist, "08:00.1,type=3Dnormal", > #ifdef RTE_LIBRTE_PMD_RING > -- > 1.9.2 Thanks for this. It works fine :) Actually, I am thinking of creating a sep= arate test for vdev, out of whitelist test, as it has no relation with it. Do you agre= e on this? Thanks, Pablo