DPDK patches and discussions
 help / color / mirror / Atom feed
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Doherty, Declan" <declan.doherty@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 0/2] link bonding unit test fix
Date: Tue, 22 Jul 2014 10:57:56 +0000	[thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D89721C35052@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <1405954337-28488-1-git-send-email-declan.doherty@intel.com>

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Declan Doherty
> Sent: Monday, July 21, 2014 3:52 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 0/2] link bonding unit test fix
> 
> 
> fix for link bonding unit tests which are failing due to change introduced in
> rte_eth_dev_configure which now explicitly checks in pmd supports link status
> chnage interrupts.
> 
> Also adds some common test macros to the test application for unit testing
> 
> 
> Declan Doherty (2):
>   test app:
>   bond: unit test suite fix
> 
>  app/test/test.c                        |   53 ++++
>  app/test/test.h                        |   82 ++++++
>  app/test/test_link_bonding.c           |  491 ++++++++++++--------------------
>  app/test/virtual_pmd.c                 |    1 +
>  lib/librte_pmd_bond/rte_eth_bond_pmd.c |   92 +++---
>  5 files changed, 356 insertions(+), 363 deletions(-)

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

I would add that it may be a good idea to implement some of the changes made in this unit test in other ones (use the new macros).

  parent reply	other threads:[~2014-07-22 10:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-21 14:52 Declan Doherty
2014-07-21 14:52 ` [dpdk-dev] [PATCH 1/2] test app: Declan Doherty
2014-07-21 14:52 ` [dpdk-dev] [PATCH 2/2] bond: unit test suite fix Declan Doherty
2014-07-22 10:57 ` De Lara Guarch, Pablo [this message]
2014-08-01 15:21   ` [dpdk-dev] [PATCH 0/2] link bonding unit test fix Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E115CCD9D858EF4F90C690B0DCB4D89721C35052@IRSMSX103.ger.corp.intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).