From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id CDC73A547 for ; Fri, 5 Sep 2014 18:10:25 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 05 Sep 2014 09:15:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,474,1406617200"; d="scan'208";a="595179751" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga002.fm.intel.com with ESMTP; 05 Sep 2014 09:15:08 -0700 Received: from irsmsx109.ger.corp.intel.com (163.33.3.23) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 5 Sep 2014 17:15:07 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.157]) by IRSMSX109.ger.corp.intel.com ([169.254.13.200]) with mapi id 14.03.0195.001; Fri, 5 Sep 2014 17:15:07 +0100 From: "De Lara Guarch, Pablo" To: "Richardson, Bruce" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 3/6] mbuf: remove rte_ctrlmbuf Thread-Index: AQHPwtbK37/Er7+iYEmJzJPNGBA/yZvyw1KA Date: Fri, 5 Sep 2014 16:15:06 +0000 Message-ID: References: <1409154628-30825-1-git-send-email-bruce.richardson@intel.com> <1409240559-14447-4-git-send-email-bruce.richardson@intel.com> In-Reply-To: <1409240559-14447-4-git-send-email-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 3/6] mbuf: remove rte_ctrlmbuf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Sep 2014 16:10:26 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > Sent: Thursday, August 28, 2014 4:43 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 3/6] mbuf: remove rte_ctrlmbuf >=20 > From: Olivier Matz >=20 > The initial role of rte_ctrlmbuf is to carry generic messages (data > pointer + data length) but it's not used by the DPDK or it applications. > Keeping it implies: > - loosing 1 byte in the rte_mbuf structure > - having some dead code rte_mbuf.[ch] >=20 > This patch removes this feature. Thanks to it, it is now possible to > simplify the rte_mbuf structure by merging the rte_pktmbuf structure > in it. This is done in next commit. >=20 > Signed-off-by: Olivier Matz >=20 > * Updated patch to HEAD. > * Modified patch to retain the old function names for ctrl mbufs as > macros. This helps with app compatibility, and allows the concept > of a control mbuf to be reintroduced via a single-bit flag in > a future change. > * Updated the packet framework ip_pipeline example application to > work following this change. >=20 > Changes in v2: > * Fixed whitespace errors introduced by this patch flagged by checkpatch >=20 > Signed-off-by: Bruce Richardson Acked-by Pablo de Lara