From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id DB9B8A547 for ; Fri, 5 Sep 2014 18:16:48 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 05 Sep 2014 09:21:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,474,1406617200"; d="scan'208";a="568943642" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga001.jf.intel.com with ESMTP; 05 Sep 2014 09:21:22 -0700 Received: from irsmsx152.ger.corp.intel.com (163.33.192.66) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 5 Sep 2014 17:21:21 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.157]) by IRSMSX152.ger.corp.intel.com ([169.254.6.48]) with mapi id 14.03.0195.001; Fri, 5 Sep 2014 17:21:21 +0100 From: "De Lara Guarch, Pablo" To: "Richardson, Bruce" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 6/6] mbuf: flatten struct vlan_macip into mbuf struct Thread-Index: AQHPwtorTR+55KA+OUysoJ0C3dEfnZvyxCMg Date: Fri, 5 Sep 2014 16:21:20 +0000 Message-ID: References: <1409154628-30825-1-git-send-email-bruce.richardson@intel.com> <1409240559-14447-7-git-send-email-bruce.richardson@intel.com> In-Reply-To: <1409240559-14447-7-git-send-email-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 6/6] mbuf: flatten struct vlan_macip into mbuf struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Sep 2014 16:16:49 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > Sent: Thursday, August 28, 2014 4:43 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v2 6/6] mbuf: flatten struct vlan_macip into > mbuf struct >=20 > The vlan_macip structure combined a vlan tag id with l2 and l3 headers > lengths for tracking offloads. However, this structure was only used as > a unit by the e1000 and ixgbe drivers, not generally. >=20 > This patch removes the structure from the mbuf header and places the > fields into the mbuf structure directly at the required point, without > any net effect on the structure layout. This allows us to treat the vlan > tags and header length fields as separate for future mbuf changes. The > drivers which were written to use the combined structure still do so, > using a driver-local definition of it. >=20 > Changes in V2: > * None >=20 > Signed-off-by: Bruce Richardson After applying this patch, I see a performance degradation (around 5%) usin= g testpmd with the default RX path, so this may require a v3 patch. Thanks, Pablo