From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 1613FB368 for ; Tue, 9 Sep 2014 17:16:04 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP; 09 Sep 2014 08:14:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,491,1406617200"; d="scan'208";a="570608663" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga001.jf.intel.com with ESMTP; 09 Sep 2014 08:20:12 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 9 Sep 2014 16:20:11 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.157]) by IRSMSX155.ger.corp.intel.com ([169.254.14.85]) with mapi id 14.03.0195.001; Tue, 9 Sep 2014 16:20:11 +0100 From: "De Lara Guarch, Pablo" To: "Richardson, Bruce" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3 6/6] mbuf: flatten struct vlan_macip into mbuf struct Thread-Index: AQHPzDxNceSRcdpkdkOL/REQp1os/Zv46kpA Date: Tue, 9 Sep 2014 15:20:10 +0000 Message-ID: References: <540D71BF.8050006@6wind.com> <1410273656-4567-1-git-send-email-bruce.richardson@intel.com> In-Reply-To: <1410273656-4567-1-git-send-email-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 6/6] mbuf: flatten struct vlan_macip into mbuf struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Sep 2014 15:16:05 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > Sent: Tuesday, September 09, 2014 3:41 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3 6/6] mbuf: flatten struct vlan_macip into > mbuf struct >=20 > The vlan_macip structure combined a vlan tag id with l2 and l3 headers > lengths for tracking offloads. However, this structure was only used as > a unit by the e1000 and ixgbe drivers, not generally. >=20 > This patch removes the structure from the mbuf header and places the > fields into the mbuf structure directly at the required point, without > any net effect on the structure layout. This allows us to treat the vlan > tags and header length fields as separate for future mbuf changes. The > drivers which were written to use the combined structure still do so, > using a driver-local definition of it. >=20 > Changes in V2: > * None >=20 > Changes in V3: > * minor comment cleanup following review by Olivier > * reduce perf regression caused by splitting vlan_macip field. This is > done by providing a single uint16_t value to allow writing/clearing > the l2 and l3 lengths together. There is still a small perf hit to the > slow path TX due to the reads from vlan_tci and l2/l3 lengths being > separated. (<5% in my tests with testpmd with no extra params). > Unfortunately, this cannot be eliminated, without restoring the vlan > tags and l2/l3 lengths as a combined 32-bit field. This would prevent > us from ever looking to move those fields about and is an artificial ti= e > that applies only for performance in igb and ixgbe drivers. Therefore, > this patch keeps the vlan_tci field separate from the lengths as the > best solution going forward. >=20 > Signed-off-by: Bruce Richardson > V2 Acked-by: Olivier Matz V3 Acked-by: Pablo de Lara