From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: David Marchand <david.marchand@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 0/2] Added functions to get RX/TX default configuration
Date: Mon, 29 Sep 2014 14:02:06 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D89722628293@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D89722628264@IRSMSX108.ger.corp.intel.com>
Hi David,
> From: David Marchand [mailto:david.marchand@6wind.com]
> Sent: Saturday, September 27, 2014 7:45 PM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 0/2] Added functions to get RX/TX default
> configuration
>
> Hello Pablo,
> - All I can see in this patchset is stuff that should remain in the PMD (since
> this is really specific to them).
>
> - Anyway, if you want to let application get this information, why the new API
> ?
> From my point of view, this should go in rte_eth_dev_info_get().
Thanks for the comments. Main changes are in the PMDs, and I only added two functions in rte_ethdev.c, which basically calls the functions in the PMDs.
Anyway, so you suggest to modify the rte_eth_dev_info structure, so it also contains these two structures populated with the default values?
Thanks,
Pablo
>
>
> --
> David Marchand
>
> On Fri, Sep 26, 2014 at 4:19 PM, Pablo de Lara
> <pablo.de.lara.guarch@intel.com> wrote:
> These patches add two new API functions to get an optimal values
> for the RX/TX configuration structures (rte_eth_rxconf and rte_eth_txconf),
> so users can get these configurations and modify or use them directly,
> to set up RX/TX queues. Besides, most of the apps that were modifying little
> or none of the default values of the structures, have been modified to use
> these functions to simplify the code and avoid duplication.
>
> Pablo de Lara (2):
> pmd: Added rte_eth_rxconf_defaults and rte_eth_txconf defaults
> functions
> app: Used rte_eth_rxconf_defaults and rte_eth_txconf_defaults in apps
>
> examples/dpdk_qat/main.c | 44 ++-----------
> examples/exception_path/main.c | 30 +--------
> examples/ip_fragmentation/main.c | 42 ++-----------
> examples/ip_reassembly/main.c | 44 ++-----------
> examples/ipv4_multicast/main.c | 44 ++-----------
> examples/kni/main.c | 34 +---------
> examples/l2fwd-ivshmem/host/host.c | 43 +-----------
> examples/l2fwd/main.c | 48 +-------------
> examples/l3fwd-acl/main.c | 46 ++------------
> examples/l3fwd-power/main.c | 46 ++-----------
> examples/l3fwd-vf/main.c | 31 ++-------
> examples/l3fwd/main.c | 54 +++-------------
> examples/link_status_interrupt/main.c | 43 +-----------
> examples/load_balancer/init.c | 24 +------
> .../client_server_mp/mp_server/init.c | 41 +-----------
> examples/multi_process/l2fwd_fork/main.c | 44 +------------
> examples/multi_process/symmetric_mp/main.c | 36 +---------
> examples/netmap_compat/bridge/bridge.c | 25 -------
> examples/netmap_compat/lib/compat_netmap.c | 6 +-
> examples/netmap_compat/lib/compat_netmap.h | 2 -
> examples/qos_meter/main.c | 36 ++++-------
> examples/quota_watermark/qw/init.c | 26 ++------
> examples/vhost_xen/main.c | 31 ++-------
> examples/vmdq/main.c | 60 ++---------------
> examples/vmdq_dcb/main.c | 36 +---------
> lib/librte_ether/rte_ethdev.c | 68 ++++++++++++++++++++
> lib/librte_ether/rte_ethdev.h | 29 ++++++++
> lib/librte_pmd_e1000/igb_ethdev.c | 56 ++++++++++++++++-
> lib/librte_pmd_i40e/i40e_ethdev.c | 56 ++++++++++++++++
> lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 59 +++++++++++++++++
> 30 files changed, 385 insertions(+), 799 deletions(-)
>
> --
> 1.7.7.6
next prev parent reply other threads:[~2014-09-29 13:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 14:19 Pablo de Lara
2014-09-26 14:19 ` [dpdk-dev] [PATCH 1/2] pmd: Added rte_eth_rxconf_defaults and rte_eth_txconf defaults functions Pablo de Lara
2014-09-26 14:19 ` [dpdk-dev] [PATCH 2/2] app: Used rte_eth_rxconf_defaults and rte_eth_txconf_defaults in apps Pablo de Lara
2014-09-27 18:45 ` [dpdk-dev] [PATCH 0/2] Added functions to get RX/TX default configuration David Marchand
[not found] ` <E115CCD9D858EF4F90C690B0DCB4D89722628264@IRSMSX108.ger.corp.intel.com>
2014-09-29 14:02 ` De Lara Guarch, Pablo [this message]
2014-09-29 14:40 ` David Marchand
2014-10-01 8:00 ` [dpdk-dev] [PATCH v2 0/2] Get default RX/TX configuration Pablo de Lara
2014-10-01 8:00 ` [dpdk-dev] [PATCH v2 1/2] pmd: Modified dev_info structure to include " Pablo de Lara
2014-10-01 8:38 ` Bruce Richardson
2014-10-01 8:42 ` Bruce Richardson
2014-10-01 8:45 ` David Marchand
2014-10-01 8:00 ` [dpdk-dev] [PATCH v2 2/2] app: Used default RX/TX configuration got from dev info in apps Pablo de Lara
2014-10-01 9:49 ` [dpdk-dev] [PATCH v3 0/3] Get default RX/TX configuration Pablo de Lara
2014-10-01 9:49 ` [dpdk-dev] [PATCH v3 1/3] ether: Reset whole dev info structure Pablo de Lara
2014-10-10 11:08 ` Thomas Monjalon
2014-10-01 9:49 ` [dpdk-dev] [PATCH v3 2/3] pmd: Modified dev_info structure to include default RX/TX configuration Pablo de Lara
2014-10-10 11:14 ` Thomas Monjalon
2014-10-10 12:05 ` De Lara Guarch, Pablo
2014-10-01 9:49 ` [dpdk-dev] [PATCH v3 3/3] app: Used default RX/TX configuration got from dev info in apps Pablo de Lara
2014-10-10 11:20 ` Thomas Monjalon
2014-10-10 12:07 ` De Lara Guarch, Pablo
2014-10-01 9:54 ` [dpdk-dev] [PATCH v3 0/3] Get default RX/TX configuration De Lara Guarch, Pablo
2014-10-02 10:18 ` David Marchand
2014-10-10 12:48 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D89722628293@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).