From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 11A90803F for ; Fri, 10 Oct 2014 13:59:54 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 10 Oct 2014 05:07:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,691,1406617200"; d="scan'208";a="612427972" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by fmsmga002.fm.intel.com with ESMTP; 10 Oct 2014 05:07:18 -0700 Received: from irsmsx152.ger.corp.intel.com (163.33.192.66) by IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 10 Oct 2014 13:05:29 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.21]) by IRSMSX152.ger.corp.intel.com ([169.254.6.118]) with mapi id 14.03.0195.001; Fri, 10 Oct 2014 13:05:29 +0100 From: "De Lara Guarch, Pablo" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v3 2/3] pmd: Modified dev_info structure to include default RX/TX configuration Thread-Index: AQHP3Vz/IlD/HlIeSEG4YYf+gVgFZZwpKxkAgAAeqrA= Date: Fri, 10 Oct 2014 12:05:28 +0000 Message-ID: References: <1412150458-26213-1-git-send-email-pablo.de.lara.guarch@intel.com> <1412156945-6549-1-git-send-email-pablo.de.lara.guarch@intel.com> <1412156945-6549-3-git-send-email-pablo.de.lara.guarch@intel.com> <1430683.lO0q5i9e6O@xps13> In-Reply-To: <1430683.lO0q5i9e6O@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 2/3] pmd: Modified dev_info structure to include default RX/TX configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Oct 2014 11:59:55 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, October 10, 2014 12:14 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 2/3] pmd: Modified dev_info structure t= o > include default RX/TX configuration >=20 > Pablo, I have some minor nits on this patchset. > If you agree, I can fix them before applying the patchset. Sure, those changes seem reasonable. Many thanks, Pablo >=20 > 2014-10-01 10:49, Pablo de Lara: > > +/** > > + * Default values for port configuration > > + */ > > +#define IGB_DEFAULT_RX_FREE_THRESH 32 > > +#define IGB_DEFAULT_RX_PTHRESH 8 > > +#define IGB_DEFAULT_RX_HTHRESH 8 > > +#define IGB_DEFAULT_RX_WTHRESH 0 > > + > > +#define IGB_DEFAULT_TX_PTHRESH 32 > > +#define IGB_DEFAULT_TX_HTHRESH 0 > > +#define IGB_DEFAULT_TX_WTHRESH 0 >=20 > Comments in .c files are not for doxygen. So /** should be replaced by /* >=20 > > static int eth_igb_get_5tuple_filter(struct rte_eth_dev *dev, > > uint16_t index, > > struct rte_5tuple_filter *filter, uint16_t *rx_queue); > > - > > /* > > * Define VF Stats MACRO for Non "cleared on read" register > > */ >=20 > This blank line shouldn't be removed. Probably a typo? >=20 > -- > Thomas