From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 3/3] app: Used default RX/TX configuration got from dev info in apps
Date: Fri, 10 Oct 2014 12:07:15 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8972262AC7B@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1721581.qMqM6R3vXa@xps13>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Friday, October 10, 2014 12:21 PM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 3/3] app: Used default RX/TX
> configuration got from dev info in apps
>
> 2014-10-01 10:49, Pablo de Lara:
> > For apps that were using default rte_eth_rxconf and rte_eth_txconf
> > structures, these have been removed and now they are obtained by
> > calling rte_eth_dev_info_get, just before setting up RX/TX queues.
>
> If my understanding is correct, you are cleaning only examples whose
> you are sure we want default values or you know which parameter to tune.
> Right?
>
> I'd like to see another patch for testpmd and other tests/examples whose
> default values would be OK.
That's correct. I have only changed those sample apps that use default values
or have very minor changes that I am aware of.
Thanks,
Pablo
>
> Thanks
> --
> Thomas
next prev parent reply other threads:[~2014-10-10 11:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 14:19 [dpdk-dev] [PATCH 0/2] Added functions to get RX/TX default configuration Pablo de Lara
2014-09-26 14:19 ` [dpdk-dev] [PATCH 1/2] pmd: Added rte_eth_rxconf_defaults and rte_eth_txconf defaults functions Pablo de Lara
2014-09-26 14:19 ` [dpdk-dev] [PATCH 2/2] app: Used rte_eth_rxconf_defaults and rte_eth_txconf_defaults in apps Pablo de Lara
2014-09-27 18:45 ` [dpdk-dev] [PATCH 0/2] Added functions to get RX/TX default configuration David Marchand
[not found] ` <E115CCD9D858EF4F90C690B0DCB4D89722628264@IRSMSX108.ger.corp.intel.com>
2014-09-29 14:02 ` De Lara Guarch, Pablo
2014-09-29 14:40 ` David Marchand
2014-10-01 8:00 ` [dpdk-dev] [PATCH v2 0/2] Get default RX/TX configuration Pablo de Lara
2014-10-01 8:00 ` [dpdk-dev] [PATCH v2 1/2] pmd: Modified dev_info structure to include " Pablo de Lara
2014-10-01 8:38 ` Bruce Richardson
2014-10-01 8:42 ` Bruce Richardson
2014-10-01 8:45 ` David Marchand
2014-10-01 8:00 ` [dpdk-dev] [PATCH v2 2/2] app: Used default RX/TX configuration got from dev info in apps Pablo de Lara
2014-10-01 9:49 ` [dpdk-dev] [PATCH v3 0/3] Get default RX/TX configuration Pablo de Lara
2014-10-01 9:49 ` [dpdk-dev] [PATCH v3 1/3] ether: Reset whole dev info structure Pablo de Lara
2014-10-10 11:08 ` Thomas Monjalon
2014-10-01 9:49 ` [dpdk-dev] [PATCH v3 2/3] pmd: Modified dev_info structure to include default RX/TX configuration Pablo de Lara
2014-10-10 11:14 ` Thomas Monjalon
2014-10-10 12:05 ` De Lara Guarch, Pablo
2014-10-01 9:49 ` [dpdk-dev] [PATCH v3 3/3] app: Used default RX/TX configuration got from dev info in apps Pablo de Lara
2014-10-10 11:20 ` Thomas Monjalon
2014-10-10 12:07 ` De Lara Guarch, Pablo [this message]
2014-10-01 9:54 ` [dpdk-dev] [PATCH v3 0/3] Get default RX/TX configuration De Lara Guarch, Pablo
2014-10-02 10:18 ` David Marchand
2014-10-10 12:48 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8972262AC7B@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).