From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 5591C803F for ; Fri, 10 Oct 2014 13:59:54 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 10 Oct 2014 05:07:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,691,1406617200"; d="scan'208";a="603333180" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga001.fm.intel.com with ESMTP; 10 Oct 2014 05:07:17 -0700 Received: from irsmsx105.ger.corp.intel.com (163.33.3.28) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 10 Oct 2014 13:07:16 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.21]) by IRSMSX105.ger.corp.intel.com ([169.254.7.174]) with mapi id 14.03.0195.001; Fri, 10 Oct 2014 13:07:15 +0100 From: "De Lara Guarch, Pablo" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH v3 3/3] app: Used default RX/TX configuration got from dev info in apps Thread-Index: AQHP5HxgHBeBV0qCj06hm/TEn4pynZwpPBMQ Date: Fri, 10 Oct 2014 12:07:15 +0000 Message-ID: References: <1412150458-26213-1-git-send-email-pablo.de.lara.guarch@intel.com> <1412156945-6549-1-git-send-email-pablo.de.lara.guarch@intel.com> <1412156945-6549-4-git-send-email-pablo.de.lara.guarch@intel.com> <1721581.qMqM6R3vXa@xps13> In-Reply-To: <1721581.qMqM6R3vXa@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 3/3] app: Used default RX/TX configuration got from dev info in apps X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Oct 2014 11:59:54 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Friday, October 10, 2014 12:21 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 3/3] app: Used default RX/TX > configuration got from dev info in apps >=20 > 2014-10-01 10:49, Pablo de Lara: > > For apps that were using default rte_eth_rxconf and rte_eth_txconf > > structures, these have been removed and now they are obtained by > > calling rte_eth_dev_info_get, just before setting up RX/TX queues. >=20 > If my understanding is correct, you are cleaning only examples whose > you are sure we want default values or you know which parameter to tune. > Right? >=20 > I'd like to see another patch for testpmd and other tests/examples whose > default values would be OK. That's correct. I have only changed those sample apps that use default valu= es=20 or have very minor changes that I am aware of. Thanks, Pablo >=20 > Thanks > -- > Thomas