From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 56F798BA for ; Wed, 15 Oct 2014 17:55:48 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 15 Oct 2014 09:03:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,725,1406617200"; d="scan'208";a="614977656" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga002.fm.intel.com with ESMTP; 15 Oct 2014 09:02:09 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.21]) by IRSMSX101.ger.corp.intel.com ([169.254.1.201]) with mapi id 14.03.0195.001; Wed, 15 Oct 2014 17:01:20 +0100 From: "De Lara Guarch, Pablo" To: "Liu, Jijiang" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v5 4/8]librte_ether:add a common filter API Thread-Index: AQHP5RggfROQBkzJQEK2KXnfI24S+pwxRByQ Date: Wed, 15 Oct 2014 16:01:20 +0000 Message-ID: References: <1413006935-22535-1-git-send-email-jijiang.liu@intel.com> <1413006935-22535-5-git-send-email-jijiang.liu@intel.com> In-Reply-To: <1413006935-22535-5-git-send-email-jijiang.liu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 4/8]librte_ether:add a common filter API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Oct 2014 15:55:49 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu > Sent: Saturday, October 11, 2014 6:56 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v5 4/8]librte_ether:add a common filter API >=20 > Introduce a new filter framewok in librte_ether. As to the implemetation > discussion, please refer to > http://dpdk.org/ml/archives/dev/2014-September/005179.html, and VxLAN > tunnel filter implementation is based on > it. >=20 > Signed-off-by: Jijiang Liu > Acked-by: Helin Zhang > Acked-by: Jingjing Wu >=20 > --- > lib/librte_ether/Makefile | 1 + > lib/librte_ether/rte_eth_ctrl.h | 152 > +++++++++++++++++++++++++++++++++++++++ > lib/librte_ether/rte_ethdev.c | 32 ++++++++ > lib/librte_ether/rte_ethdev.h | 56 +++++++++++--- > 4 files changed, 229 insertions(+), 12 deletions(-) > create mode 100644 lib/librte_ether/rte_eth_ctrl.h >=20 [...] > +++ b/lib/librte_ether/rte_eth_ctrl.h [...] > +/** > + * Tunnel Packet filter configuration. > + */ > +struct rte_eth_tunnel_filter_conf { > + struct ether_addr *outer_mac; /**< Outer MAC address fiter. */ > + struct ether_addr *inner_mac; /**< Inner MAC address fiter. */ > + uint16_t inner_vlan; /**< Inner VLAN fiter. */ > + enum rte_tunnel_iptype ip_type; /**< IP address type. */ > + union { > + uint32_t ipv4_addr; /**< IPv4 source address to match. */ > + uint32_t ipv6_addr[4]; /**< IPv6 source address to match. */ > + } ip_addr; /**< IPv4/IPv6 source address to match (union of above). > */ > + > + uint8_t filter_type; /**< Filter type. */ This should be enum rte_tunnel_filter_type filter_type, and not uint8_t fil= ter_type. > + uint8_t to_queue; /**< Use MAC and VLAN to point to a queue. > */ > + enum rte_eth_tunnel_type tunnel_type; /**< Tunnel Type. */ > + uint32_t tenant_id; /** < Tenant number. */ > + uint16_t queue_id; /** < queue number. */ > +}; > + [...]