From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id BA4E37E72 for ; Thu, 16 Oct 2014 12:11:19 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 16 Oct 2014 03:09:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,731,1406617200"; d="scan'208";a="606352134" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga001.fm.intel.com with ESMTP; 16 Oct 2014 03:19:10 -0700 Received: from irsmsx107.ger.corp.intel.com (163.33.3.99) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 16 Oct 2014 11:19:09 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.21]) by IRSMSX107.ger.corp.intel.com ([169.254.10.68]) with mapi id 14.03.0195.001; Thu, 16 Oct 2014 11:19:09 +0100 From: "De Lara Guarch, Pablo" To: "De Lara Guarch, Pablo" , "Liu, Jijiang" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v5 2/8]i40e:support VxLAN packet identification in librte_pmd_i40e Thread-Index: AQHP5RgTODrYrJwTpUy7GE5CuRcioZwuNqEwgART1yA= Date: Thu, 16 Oct 2014 10:19:09 +0000 Message-ID: References: <1413006935-22535-1-git-send-email-jijiang.liu@intel.com> <1413006935-22535-3-git-send-email-jijiang.liu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v5 2/8]i40e:support VxLAN packet identification in librte_pmd_i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Oct 2014 10:11:20 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Monday, October 13, 2014 5:13 PM > To: Liu, Jijiang; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v5 2/8]i40e:support VxLAN packet > identification in librte_pmd_i40e >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu > > Sent: Saturday, October 11, 2014 6:55 AM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH v5 2/8]i40e:support VxLAN packet > identification > > in librte_pmd_i40e > > > > Support tunneling UDP port configuration on i40e in librte_pmd_i40e. > > Currently, only VxLAN is implemented, which include > > - VxLAN UDP port initialization > > - Implement the APIs to configure VxLAN UDP port in librte_pmd_i40e. > > > > Signed-off-by: Jijiang Liu > > Acked-by: Helin Zhang > > Acked-by: Jingjing Wu > > Acked-by: Jing Chen > > [...] > > index 7c5b6a8..369bc3b 100644 > > --- a/lib/librte_pmd_i40e/i40e_rxtx.c > > +++ b/lib/librte_pmd_i40e/i40e_rxtx.c > > @@ -638,6 +638,10 @@ i40e_rx_scan_hw_ring(struct i40e_rx_queue *rxq) > > pkt_flags |=3D i40e_rxd_error_to_pkt_flags(qword1); > > pkt_flags |=3D i40e_rxd_ptype_to_pkt_flags(qword1); > > mb->ol_flags =3D pkt_flags; > > + > > + mb->packet_type =3D (uint16_t)((qword1 & > > + I40E_RXD_QW1_PTYPE_MASK) >> > > + I40E_RXD_QW1_PTYPE_SHIFT); > > if (pkt_flags & PKT_RX_RSS_HASH) > > mb->hash.rss =3D rte_le_to_cpu_32(\ > > rxdp->wb.qword0.hi_dword.rss); > > @@ -873,6 +877,8 @@ i40e_recv_pkts(void *rx_queue, struct rte_mbuf > > **rx_pkts, uint16_t nb_pkts) > > pkt_flags =3D i40e_rxd_status_to_pkt_flags(qword1); > > pkt_flags |=3D i40e_rxd_error_to_pkt_flags(qword1); > > pkt_flags |=3D i40e_rxd_ptype_to_pkt_flags(qword1); > > + rxm->packet_type =3D (uint16_t)((qword1 & > > I40E_RXD_QW1_PTYPE_MASK) >> > > + I40E_RXD_QW1_PTYPE_SHIFT); > > rxm->ol_flags =3D pkt_flags; > > if (pkt_flags & PKT_RX_RSS_HASH) > > rxm->hash.rss =3D > > @@ -1027,6 +1033,9 @@ i40e_recv_scattered_pkts(void *rx_queue, > > pkt_flags =3D i40e_rxd_status_to_pkt_flags(qword1); > > pkt_flags |=3D i40e_rxd_error_to_pkt_flags(qword1); > > pkt_flags |=3D i40e_rxd_ptype_to_pkt_flags(qword1); > > + first_seg->packet_type =3D (uint8_t)((qword1 & > > + I40E_RXD_QW1_PTYPE_MASK) >> > > + I40E_RXD_QW1_PTYPE_SHIFT); Another comment is that packet_type is uint16_t, so you should change that = uint8_t to uint16_t. Thanks! > > first_seg->ol_flags =3D pkt_flags; > > if (pkt_flags & PKT_RX_RSS_HASH) > > rxm->hash.rss =3D > > -- > > 1.7.7.6