From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 4E8777E79
 for <dev@dpdk.org>; Thu, 16 Oct 2014 14:35:43 +0200 (CEST)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga101.fm.intel.com with ESMTP; 16 Oct 2014 05:43:35 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.04,731,1406617200"; d="scan'208";a="615500046"
Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155])
 by fmsmga002.fm.intel.com with ESMTP; 16 Oct 2014 05:43:34 -0700
Received: from irsmsx151.ger.corp.intel.com (163.33.192.59) by
 IRSMSX102.ger.corp.intel.com (163.33.3.155) with Microsoft SMTP Server (TLS)
 id 14.3.195.1; Thu, 16 Oct 2014 13:41:53 +0100
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.21]) by
 IRSMSX151.ger.corp.intel.com ([169.254.4.146]) with mapi id 14.03.0195.001;
 Thu, 16 Oct 2014 13:41:53 +0100
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Liu, Jijiang" <jijiang.liu@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v5 4/8]librte_ether:add a common filter API
Thread-Index: AQHP5RggfROQBkzJQEK2KXnfI24S+pwysN7g
Date: Thu, 16 Oct 2014 12:41:52 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8972262C8DC@IRSMSX108.ger.corp.intel.com>
References: <1413006935-22535-1-git-send-email-jijiang.liu@intel.com>
 <1413006935-22535-5-git-send-email-jijiang.liu@intel.com>
In-Reply-To: <1413006935-22535-5-git-send-email-jijiang.liu@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v5 4/8]librte_ether:add a common filter API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 16 Oct 2014 12:35:43 -0000



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jijiang Liu
> Sent: Saturday, October 11, 2014 6:56 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v5 4/8]librte_ether:add a common filter API
>=20
> Introduce a new filter framewok in librte_ether. As to the implemetation
> discussion, please refer to
> http://dpdk.org/ml/archives/dev/2014-September/005179.html, and VxLAN
> tunnel filter implementation is based on
> it.
>=20
> Signed-off-by: Jijiang Liu <jijiang.liu@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>
>=20
[..]

> new file mode 100644
> index 0000000..574e9ff
> --- /dev/null
> +++ b/lib/librte_ether/rte_eth_ctrl.h

[...]
> +/**
> + * All generic operations to filters
> + */
> +enum rte_filter_op {
> +	/**< used to check whether the type filter is supported */

Shouldn't be this comment below?

> +	RTE_ETH_FILTER_OP_NONE =3D 0,
> +	RTE_ETH_FILTER_OP_ADD,      /**< add filter entry */
> +	RTE_ETH_FILTER_OP_UPDATE,   /**< update filter entry */
> +	RTE_ETH_FILTER_OP_DELETE,   /**< delete filter entry */
> +	RTE_ETH_FILTER_OP_GET,      /**< get filter entry */
> +	RTE_ETH_FILTER_OP_SET,      /**< configurations */
> +	/**< get information of filter, such as status or statistics */

Same here

> +	RTE_ETH_FILTER_OP_GET_INFO,
> +	RTE_ETH_FILTER_OP_MAX,
> +};
> +