DPDK patches and discussions
 help / color / mirror / Atom feed
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] test: fbk hash - fix errors with large nb entries
Date: Mon, 20 Oct 2014 12:32:04 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8972262D843@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1413551892-12573-1-git-send-email-bruce.richardson@intel.com>



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson
> Sent: Friday, October 17, 2014 2:18 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] test: fbk hash - fix errors with large nb entries
> 
> The four-byte-key (fbk) autotest was allocating the keys to be used for
> the test on the stack. When the number of entries in the table was
> increased significantly, for example, to test larger hashes by increase the
> value of ENTRIES, this array of keys was greater than that
> allowed on the stack, and so caused problems, i.e. crashes and core dumps.
> 
> The solution is to have the keys dynamically allocated on the heap using
> malloc. Now if ENTRIES is increased and we run out of memory we get an
> error message instead of a crash.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

  reply	other threads:[~2014-10-20 12:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-17 13:18 Bruce Richardson
2014-10-20 12:32 ` De Lara Guarch, Pablo [this message]
     [not found] <1413545645-29168-1-git-send-email-y>
2014-10-17 11:38 ` Bruce Richardson
2014-10-17 11:49   ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8972262D843@IRSMSX108.ger.corp.intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git