From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 6C3C6685D for ; Mon, 20 Oct 2014 14:24:41 +0200 (CEST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 20 Oct 2014 05:32:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,756,1406617200"; d="scan'208";a="608072758" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by fmsmga001.fm.intel.com with ESMTP; 20 Oct 2014 05:32:50 -0700 Received: from irsmsx152.ger.corp.intel.com (163.33.192.66) by IRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP Server (TLS) id 14.3.195.1; Mon, 20 Oct 2014 13:32:05 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.21]) by IRSMSX152.ger.corp.intel.com ([169.254.6.118]) with mapi id 14.03.0195.001; Mon, 20 Oct 2014 13:32:05 +0100 From: "De Lara Guarch, Pablo" To: "Richardson, Bruce" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] test: fbk hash - fix errors with large nb entries Thread-Index: AQHP6g0Wdmg24Cgd9EOGNta3sJ5f7Jw47xew Date: Mon, 20 Oct 2014 12:32:04 +0000 Message-ID: References: <1413551892-12573-1-git-send-email-bruce.richardson@intel.com> In-Reply-To: <1413551892-12573-1-git-send-email-bruce.richardson@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] test: fbk hash - fix errors with large nb entries X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Oct 2014 12:24:41 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > Sent: Friday, October 17, 2014 2:18 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] test: fbk hash - fix errors with large nb ent= ries >=20 > The four-byte-key (fbk) autotest was allocating the keys to be used for > the test on the stack. When the number of entries in the table was > increased significantly, for example, to test larger hashes by increase t= he > value of ENTRIES, this array of keys was greater than that > allowed on the stack, and so caused problems, i.e. crashes and core dumps= . >=20 > The solution is to have the keys dynamically allocated on the heap using > malloc. Now if ENTRIES is increased and we run out of memory we get an > error message instead of a crash. >=20 > Signed-off-by: Bruce Richardson Acked-by: Pablo de Lara