From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id A006F7E7B for ; Wed, 22 Oct 2014 12:14:42 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 22 Oct 2014 03:23:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.04,768,1406617200"; d="scan'208";a="618433392" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by fmsmga002.fm.intel.com with ESMTP; 22 Oct 2014 03:23:00 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 22 Oct 2014 11:22:59 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.21]) by IRSMSX155.ger.corp.intel.com ([169.254.14.70]) with mapi id 14.03.0195.001; Wed, 22 Oct 2014 11:22:59 +0100 From: "De Lara Guarch, Pablo" To: Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] librte_ip_frag: Disable ipv4/v6 fragmentation if RTE_MBUF_REFCNT=n Thread-Index: AQHP7XO3rwARPAEozEypyGyRo/1u/pw76PyQ Date: Wed, 22 Oct 2014 10:22:59 +0000 Message-ID: References: <1413900943-27711-1-git-send-email-pablo.de.lara.guarch@intel.com> <6121476.at0lcZkNCO@xps13> In-Reply-To: <6121476.at0lcZkNCO@xps13> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] librte_ip_frag: Disable ipv4/v6 fragmentation if RTE_MBUF_REFCNT=n X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Oct 2014 10:14:43 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Tuesday, October 21, 2014 10:12 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] librte_ip_frag: Disable ipv4/v6 > fragmentation if RTE_MBUF_REFCNT=3Dn >=20 > 2014-10-21 15:15, Pablo de Lara: > > Ipv4/v6 fragmentation libraries depends on refcnt. > > There was a compilation error if RTE_MBUF_REFCNT was disabled, > > so those libraries have been disabled in that situation. >=20 > Please Pablo, could you add a short justification that it's not > possible to implement fragmentation without refcnt (at least with > the current design)? Will send a v2 with it. >=20 > What do you think of adding a warning as below? >=20 > > +ifeq ($(CONFIG_RTE_MBUF_REFCNT),y) > > SRCS-$(CONFIG_RTE_LIBRTE_IP_FRAG) +=3D rte_ipv4_fragmentation.c > > -SRCS-$(CONFIG_RTE_LIBRTE_IP_FRAG) +=3D rte_ipv4_reassembly.c > > SRCS-$(CONFIG_RTE_LIBRTE_IP_FRAG) +=3D rte_ipv6_fragmentation.c > +else > +$(info WARNING: Fragmentation feature is disabled because it needs > MBUF_REFCNT.) > > +endif > > +SRCS-$(CONFIG_RTE_LIBRTE_IP_FRAG) +=3D rte_ipv4_reassembly.c Good idea. Thanks Thomas! >=20 > -- > Thomas