Re: [dpdk-dev] [PATCH] bond: disabling broadcast mode when dpdk is built without RTE_MBUF_REFCNT

["De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>]

Hi Declan,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Declan Doherty
> Sent: Wednesday, October 22, 2014 11:29 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] bond: disabling broadcast mode when dpdk is
> built without RTE_MBUF_REFCNT
> 
> Link bonding broadcast mode requires refcnt parameter in the mbuf struct to
> allow efficient transmission of duplicated mbufs on slave ports.
> 
> This patch disables broadcast mode when the complication option
> RTE_MBUF_REFCNT
> is disabled to allow clean building of the bonding library
> 
> 
> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
> ---
>  app/test/test_link_bonding.c            |    9 ++++++++-
>  lib/librte_pmd_bond/rte_eth_bond.h      |    3 ++-
>  lib/librte_pmd_bond/rte_eth_bond_args.c |    2 ++
>  lib/librte_pmd_bond/rte_eth_bond_pmd.c  |   12 ++++++++++++
>  4 files changed, 24 insertions(+), 2 deletions(-)
> 

As suggested by Thomas in my other patch (disable ipv4/v6 fragmentation if RTE_MBUF_REFCNT=n),
 it may be useful to include a warning in the link bonding Makefile, letting the user know 
that broadcast mode is disabled due to that option not set.

Thanks,
Pablo