From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 83F567E7B for ; Wed, 22 Oct 2014 12:38:55 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 22 Oct 2014 03:47:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="404057258" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by FMSMGA003.fm.intel.com with ESMTP; 22 Oct 2014 03:39:32 -0700 Received: from irsmsx152.ger.corp.intel.com (163.33.192.66) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 22 Oct 2014 11:47:10 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.21]) by IRSMSX152.ger.corp.intel.com ([169.254.6.125]) with mapi id 14.03.0195.001; Wed, 22 Oct 2014 11:47:10 +0100 From: "De Lara Guarch, Pablo" To: "Doherty, Declan" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] bond: disabling broadcast mode when dpdk is built without RTE_MBUF_REFCNT Thread-Index: AQHP7eMcNGbmZtPYMUCDrtMnqf6V6Zw77oQw Date: Wed, 22 Oct 2014 10:47:09 +0000 Message-ID: References: <1413973724-14803-1-git-send-email-declan.doherty@intel.com> In-Reply-To: <1413973724-14803-1-git-send-email-declan.doherty@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] bond: disabling broadcast mode when dpdk is built without RTE_MBUF_REFCNT X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Oct 2014 10:38:56 -0000 Hi Declan, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Declan Doherty > Sent: Wednesday, October 22, 2014 11:29 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] bond: disabling broadcast mode when dpdk is > built without RTE_MBUF_REFCNT >=20 > Link bonding broadcast mode requires refcnt parameter in the mbuf struct = to > allow efficient transmission of duplicated mbufs on slave ports. >=20 > This patch disables broadcast mode when the complication option > RTE_MBUF_REFCNT > is disabled to allow clean building of the bonding library >=20 >=20 > Signed-off-by: Declan Doherty > --- > app/test/test_link_bonding.c | 9 ++++++++- > lib/librte_pmd_bond/rte_eth_bond.h | 3 ++- > lib/librte_pmd_bond/rte_eth_bond_args.c | 2 ++ > lib/librte_pmd_bond/rte_eth_bond_pmd.c | 12 ++++++++++++ > 4 files changed, 24 insertions(+), 2 deletions(-) >=20 As suggested by Thomas in my other patch (disable ipv4/v6 fragmentation if = RTE_MBUF_REFCNT=3Dn), it may be useful to include a warning in the link bonding Makefile, lettin= g the user know=20 that broadcast mode is disabled due to that option not set. Thanks, Pablo