From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id D925D5917 for ; Tue, 28 Oct 2014 12:36:44 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 28 Oct 2014 04:45:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="407208724" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by FMSMGA003.fm.intel.com with ESMTP; 28 Oct 2014 04:37:29 -0700 Received: from irsmsx105.ger.corp.intel.com (163.33.3.28) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 28 Oct 2014 11:45:29 +0000 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.89]) by IRSMSX105.ger.corp.intel.com ([169.254.7.56]) with mapi id 14.03.0195.001; Tue, 28 Oct 2014 11:45:28 +0000 From: "De Lara Guarch, Pablo" To: "Gonzalez Monroy, Sergio" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] mk: link combined lib using CC Thread-Index: AQHP7tfBBuxtsruDAU2UNNJGe1AyqZxFZ1JA Date: Tue, 28 Oct 2014 11:45:28 +0000 Message-ID: References: <1414078550-692-1-git-send-email-sergio.gonzalez.monroy@intel.com> In-Reply-To: <1414078550-692-1-git-send-email-sergio.gonzalez.monroy@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] mk: link combined lib using CC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Oct 2014 11:36:45 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sergio Gonzalez > Monroy > Sent: Thursday, October 23, 2014 4:36 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] mk: link combined lib using CC >=20 > Building combined shared libs fails if we set EXTRA_CFLAGS=3D-O0. >=20 > /usr/bin/ld: test: hidden symbol `mknod' in > /usr/lib64/libc_nonshared.a(mknod.oS) is referenced by DSO > /usr/bin/ld: final link failed: Bad value > collect2: error: ld returned 1 exit status >=20 > Fix: link combined shared lib using CC if LINK_USING_CC is enabled. >=20 > Signed-off-by: Sergio Gonzalez Monroy > > --- > mk/rte.lib.mk | 1 - > mk/rte.sharelib.mk | 12 +++++++++++- > 2 files changed, 11 insertions(+), 2 deletions(-) >=20 > diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk > index d83e808..a6abd6d 100644 > --- a/mk/rte.lib.mk > +++ b/mk/rte.lib.mk > @@ -63,7 +63,6 @@ ifeq ($(LINK_USING_CC),1) > # Override the definition of LD here, since we're linking with CC > LD :=3D $(CC) $(CPU_CFLAGS) > LD_MULDEFS :=3D $(call linkerprefix,-z$(comma)muldefs) > -CPU_LDFLAGS :=3D $(call linkerprefix,$(CPU_LDFLAGS)) > endif Patch does not apply cleanly, due to context mismatch.=20 Could you send a V2, based on the current branch status? Plus, should we include compilation errors in commits?=20 They are quite useful to identify the problem that=20 the patch is solving, but not sure if this should be shown in the git log. Thanks, Pablo