[dpdk-dev] [PATCH 0/2] lib/librte_vhost: coding style fixes

[dpdk-dev] [PATCH 0/2] lib/librte_vhost: coding style fixes

[Huawei Xie]

This patchset fixes serious coding style issues in vhost library.

Huawei Xie (2):
  fix alignment, lengthy lines, misordered type and other style issues 
  printk -> pr_debug

 lib/librte_vhost/eventfd_link/eventfd_link.c | 244 ++++++++++-----------
 lib/librte_vhost/eventfd_link/eventfd_link.h | 127 ++++++-----
 lib/librte_vhost/rte_virtio_net.h            |   3 +-
 lib/librte_vhost/vhost-net-cdev.c            | 187 +++++++++-------
 lib/librte_vhost/vhost_rxtx.c                |  13 +-
 lib/librte_vhost/virtio-net.c                | 317 +++++++++++++++++----------
 6 files changed, 494 insertions(+), 397 deletions(-)

-- 
1.8.1.4

Re: [dpdk-dev] [PATCH 0/2] lib/librte_vhost: coding style fixes

[De Lara Guarch, Pablo]

Hi Huawei,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Huawei Xie
> Sent: Thursday, November 06, 2014 4:46 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 0/2] lib/librte_vhost: coding style fixes
> 
> This patchset fixes serious coding style issues in vhost library.
> 
> Huawei Xie (2):
>   fix alignment, lengthy lines, misordered type and other style issues
>   printk -> pr_debug
> 
>  lib/librte_vhost/eventfd_link/eventfd_link.c | 244 ++++++++++-----------
>  lib/librte_vhost/eventfd_link/eventfd_link.h | 127 ++++++-----
>  lib/librte_vhost/rte_virtio_net.h            |   3 +-
>  lib/librte_vhost/vhost-net-cdev.c            | 187 +++++++++-------
>  lib/librte_vhost/vhost_rxtx.c                |  13 +-
>  lib/librte_vhost/virtio-net.c                | 317 +++++++++++++++++----------
>  6 files changed, 494 insertions(+), 397 deletions(-)
> 
> --
> 1.8.1.4

I assume this is the cover letter of the two patches that you sent 5 hours before. 
You should probably send this again, as it seems to not be connected to the patches 
(look here: http://dpdk.org/ml/archives/dev/2014-November/)


Thanks,
Pablo

Re: [dpdk-dev] [PATCH 0/2] lib/librte_vhost: coding style fixes

[Tetsuya Mukawa]

Hi Xie,

Do you have a plan to fix coding style of 'librte_vhost/vhost-net-cdev.h'?
Especially, PRINT_PACKET macro.

Thanks,
Tetsuya

(2014/11/06 13:46), Huawei Xie wrote:
> This patchset fixes serious coding style issues in vhost library.
>
> Huawei Xie (2):
>   fix alignment, lengthy lines, misordered type and other style issues 
>   printk -> pr_debug
>
>  lib/librte_vhost/eventfd_link/eventfd_link.c | 244 ++++++++++-----------
>  lib/librte_vhost/eventfd_link/eventfd_link.h | 127 ++++++-----
>  lib/librte_vhost/rte_virtio_net.h            |   3 +-
>  lib/librte_vhost/vhost-net-cdev.c            | 187 +++++++++-------
>  lib/librte_vhost/vhost_rxtx.c                |  13 +-
>  lib/librte_vhost/virtio-net.c                | 317 +++++++++++++++++----------
>  6 files changed, 494 insertions(+), 397 deletions(-)
>