DPDK patches and discussions
 help / color / mirror / Atom feed
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Jastrzebski, MichalX K" <michalx.k.jastrzebski@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 0/2] bond: mode 4 support
Date: Fri, 7 Nov 2014 13:48:29 +0000	[thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D897268349CF@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1415358270-12523-1-git-send-email-michalx.k.jastrzebski@intel.com>



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michal Jastrzebski
> Sent: Friday, November 07, 2014 11:04 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v3 0/2] bond: mode 4 support
> 
> From: Pawel Wodkowski <pawelx.wodkowski@intel.com>
> 
> v2 changes:
> New version handles race issues with setting/cancelin callbacks,
> fixes promiscus mode setting in mode 4 and some other minor errors in
> mode 4
> implementation.
> 
> v3 changes:
> This is a rework of previous patchset. Basic functionality i the same but
> contain following changes:
> - use one global array of slaves instead separate instance for every bonded
>   device (reduce memory usage). This also allow use of port id instead of
>   offsetting to current active slaves.
> - make mode 4 immune to partner timings standard violation.
> - fix possible buffer overflow in RX function if caller provide buffer
>   that is less than received packets (additional slow packets).
> - change/fix promiscus mode and MAC management.
> - fix compiling issues on gcc version less than 4.5
> - bring API for tunig mode 4 parameters and expose mode 4 frames
> structure.
> - prevent console flood with warning messages if mode 4 RX/TX buffers are
> full.
> 
> test-pmd:
> - add mode 4 support (force periodic TX if no packets received during 100ms
>   period). Some forwardning modes (ex. rx only) does not allow mode 4
> usage.
> - 'port start X' - check if X is valid value
> 
> changes not related to mode 4:
> - fix memcpy() usage in bond_ethdev_tx_burst_balance() (OOM/undfined
> behaviour
>   if TX burst fail)
> 
> Those patches depend from Declan Doherty v5 (rebased to be aplicable on
> top of
> commit b6583ee402656ea86c8a3b92e009a99e13726781) patchset and rte
> alarm patches.

Since Declan sent a v6 for link bonding changes, maybe it is a good idea 
to send another version, as v5 will not be merged.

Pablo

  parent reply	other threads:[~2014-11-07 13:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-07 11:04 Michal Jastrzebski
2014-11-07 11:04 ` [dpdk-dev] [PATCH v3 1/2] bond: add " Michal Jastrzebski
2014-11-07 11:15   ` Thomas Monjalon
2014-11-07 12:18     ` Jastrzebski, MichalX K
2014-11-07 13:10     ` Wodkowski, PawelX
2014-11-07 11:04 ` [dpdk-dev] [PATCH v3 2/2] test-pmd: " Michal Jastrzebski
2014-11-07 13:48 ` De Lara Guarch, Pablo [this message]
2014-11-07 15:04   ` [dpdk-dev] [PATCH v3 0/2] bond: " Wodkowski, PawelX
2014-11-07 16:58     ` De Lara Guarch, Pablo
2014-11-07 15:15   ` Wodkowski, PawelX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E115CCD9D858EF4F90C690B0DCB4D897268349CF@IRSMSX108.ger.corp.intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=dev@dpdk.org \
    --cc=michalx.k.jastrzebski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).