From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 689477EC4 for ; Fri, 7 Nov 2014 14:40:03 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP; 07 Nov 2014 05:42:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="413008565" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by FMSMGA003.fm.intel.com with ESMTP; 07 Nov 2014 05:40:36 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.82]) by IRSMSX104.ger.corp.intel.com ([169.254.5.58]) with mapi id 14.03.0195.001; Fri, 7 Nov 2014 13:48:30 +0000 From: "De Lara Guarch, Pablo" To: "Jastrzebski, MichalX K" Thread-Topic: [dpdk-dev] [PATCH v3 0/2] bond: mode 4 support Thread-Index: AQHP+nq9+DGdv6q7JU237/mBCIaVzJxVLaAA Date: Fri, 7 Nov 2014 13:48:29 +0000 Message-ID: References: <1415358270-12523-1-git-send-email-michalx.k.jastrzebski@intel.com> In-Reply-To: <1415358270-12523-1-git-send-email-michalx.k.jastrzebski@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v3 0/2] bond: mode 4 support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Nov 2014 13:40:04 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michal Jastrzebski > Sent: Friday, November 07, 2014 11:04 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH v3 0/2] bond: mode 4 support >=20 > From: Pawel Wodkowski >=20 > v2 changes: > New version handles race issues with setting/cancelin callbacks, > fixes promiscus mode setting in mode 4 and some other minor errors in > mode 4 > implementation. >=20 > v3 changes: > This is a rework of previous patchset. Basic functionality i the same but > contain following changes: > - use one global array of slaves instead separate instance for every bond= ed > device (reduce memory usage). This also allow use of port id instead of > offsetting to current active slaves. > - make mode 4 immune to partner timings standard violation. > - fix possible buffer overflow in RX function if caller provide buffer > that is less than received packets (additional slow packets). > - change/fix promiscus mode and MAC management. > - fix compiling issues on gcc version less than 4.5 > - bring API for tunig mode 4 parameters and expose mode 4 frames > structure. > - prevent console flood with warning messages if mode 4 RX/TX buffers are > full. >=20 > test-pmd: > - add mode 4 support (force periodic TX if no packets received during 100= ms > period). Some forwardning modes (ex. rx only) does not allow mode 4 > usage. > - 'port start X' - check if X is valid value >=20 > changes not related to mode 4: > - fix memcpy() usage in bond_ethdev_tx_burst_balance() (OOM/undfined > behaviour > if TX burst fail) >=20 > Those patches depend from Declan Doherty v5 (rebased to be aplicable on > top of > commit b6583ee402656ea86c8a3b92e009a99e13726781) patchset and rte > alarm patches. Since Declan sent a v6 for link bonding changes, maybe it is a good idea=20 to send another version, as v5 will not be merged. Pablo