Re: [dpdk-dev] [PATCH v3 0/2] bond: mode 4 support

["De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>]

Hi Pawel,

> -----Original Message-----
> From: Wodkowski, PawelX
> Sent: Friday, November 07, 2014 3:05 PM
> To: De Lara Guarch, Pablo; Jastrzebski, MichalX K
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v3 0/2] bond: mode 4 support
> 
> > Since Declan sent a v6 for link bonding changes, maybe it is a good idea
> > to send another version, as v5 will not be merged.
> >
> > Pablo
> Hi Pablo
> 
> I compared v6 patches vs patches produced by git rebase v5 patches
> on top which I used to produce mode 4 v3 patches and I think they are
> compatible. There is one difference is in unit tests but, fortunately I
> do not touch unit tests yet so they are be applicable. I can't fully verify
> that as I am unable to apply patches in v6.
> If you think this is insufficient perhaps I should wait for Declan's patches
> be merged into master branch.

I just checked it and it applied fine, but there is a tiny problem.
If you disable CONFIG_RTE_MBUF_REFCNT, then it hides the implementation of 
bond_ethdev_tx_burst_8023ad, and then you get a compilation error.
It is solved by just moving the condition #ifdef RTE_MBUF_REFCNT after your function,
but still this will probably need another version or maybe a patch after.

Thanks,
Pablo
> 
> $ git apply d_v6/0007*.patch -v
> Checking patch app/test-pmd/cmdline.c...
> Checking patch app/test/test.h...
> Checking patch app/test/test_link_bonding.c...
> Checking patch app/test/virtual_pmd.c...
> Checking patch app/test/virtual_pmd.h...
> Checking patch doc/guides/testpmd_app_ug/testpmd_funcs.rst...
> error: doc/guides/testpmd_app_ug/testpmd_funcs.rst: No such file or
> directory
> Checking patch lib/librte_pmd_bond/rte_eth_bond.h...
> Checking patch lib/librte_pmd_bond/rte_eth_bond_api.c...
> Checking patch lib/librte_pmd_bond/rte_eth_bond_args.c...
> Checking patch lib/librte_pmd_bond/rte_eth_bond_pmd.c...
> Checking patch lib/librte_pmd_bond/rte_eth_bond_private.h...
> 
> Pawel