DPDK patches and discussions
 help / color / mirror / Atom feed
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Wodkowski, PawelX" <pawelx.wodkowski@intel.com>,
	"Jastrzebski, MichalX K" <michalx.k.jastrzebski@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3 0/2] bond: mode 4 support
Date: Fri, 7 Nov 2014 16:58:04 +0000	[thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D89726834C81@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <F6F2A6264E145F47A18AB6DF8E87425D12B4E9A5@IRSMSX102.ger.corp.intel.com>

Hi Pawel,

> -----Original Message-----
> From: Wodkowski, PawelX
> Sent: Friday, November 07, 2014 3:05 PM
> To: De Lara Guarch, Pablo; Jastrzebski, MichalX K
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH v3 0/2] bond: mode 4 support
> 
> > Since Declan sent a v6 for link bonding changes, maybe it is a good idea
> > to send another version, as v5 will not be merged.
> >
> > Pablo
> Hi Pablo
> 
> I compared v6 patches vs patches produced by git rebase v5 patches
> on top which I used to produce mode 4 v3 patches and I think they are
> compatible. There is one difference is in unit tests but, fortunately I
> do not touch unit tests yet so they are be applicable. I can't fully verify
> that as I am unable to apply patches in v6.
> If you think this is insufficient perhaps I should wait for Declan's patches
> be merged into master branch.

I just checked it and it applied fine, but there is a tiny problem.
If you disable CONFIG_RTE_MBUF_REFCNT, then it hides the implementation of 
bond_ethdev_tx_burst_8023ad, and then you get a compilation error.
It is solved by just moving the condition #ifdef RTE_MBUF_REFCNT after your function,
but still this will probably need another version or maybe a patch after.

Thanks,
Pablo
> 
> $ git apply d_v6/0007*.patch -v
> Checking patch app/test-pmd/cmdline.c...
> Checking patch app/test/test.h...
> Checking patch app/test/test_link_bonding.c...
> Checking patch app/test/virtual_pmd.c...
> Checking patch app/test/virtual_pmd.h...
> Checking patch doc/guides/testpmd_app_ug/testpmd_funcs.rst...
> error: doc/guides/testpmd_app_ug/testpmd_funcs.rst: No such file or
> directory
> Checking patch lib/librte_pmd_bond/rte_eth_bond.h...
> Checking patch lib/librte_pmd_bond/rte_eth_bond_api.c...
> Checking patch lib/librte_pmd_bond/rte_eth_bond_args.c...
> Checking patch lib/librte_pmd_bond/rte_eth_bond_pmd.c...
> Checking patch lib/librte_pmd_bond/rte_eth_bond_private.h...
> 
> Pawel

  reply	other threads:[~2014-11-07 16:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-07 11:04 Michal Jastrzebski
2014-11-07 11:04 ` [dpdk-dev] [PATCH v3 1/2] bond: add " Michal Jastrzebski
2014-11-07 11:15   ` Thomas Monjalon
2014-11-07 12:18     ` Jastrzebski, MichalX K
2014-11-07 13:10     ` Wodkowski, PawelX
2014-11-07 11:04 ` [dpdk-dev] [PATCH v3 2/2] test-pmd: " Michal Jastrzebski
2014-11-07 13:48 ` [dpdk-dev] [PATCH v3 0/2] bond: " De Lara Guarch, Pablo
2014-11-07 15:04   ` Wodkowski, PawelX
2014-11-07 16:58     ` De Lara Guarch, Pablo [this message]
2014-11-07 15:15   ` Wodkowski, PawelX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E115CCD9D858EF4F90C690B0DCB4D89726834C81@IRSMSX108.ger.corp.intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=dev@dpdk.org \
    --cc=michalx.k.jastrzebski@intel.com \
    --cc=pawelx.wodkowski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).