From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 190F93975
 for <dev@dpdk.org>; Tue, 25 Nov 2014 15:40:18 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga102.jf.intel.com with ESMTP; 25 Nov 2014 06:48:46 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.07,455,1413270000"; d="scan'208";a="613776242"
Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75])
 by orsmga001.jf.intel.com with ESMTP; 25 Nov 2014 06:51:09 -0800
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.128]) by
 IRSMSX153.ger.corp.intel.com ([163.33.192.75]) with mapi id 14.03.0195.001;
 Tue, 25 Nov 2014 14:48:50 +0000
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] checkpatch script
Thread-Index: AdAIsKQjqi59XiglTES29FFpc9g78AAC3fWAAACZnDA=
Date: Tue, 25 Nov 2014 14:48:49 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8972685C3EF@IRSMSX108.ger.corp.intel.com>
References: <E115CCD9D858EF4F90C690B0DCB4D8972685B25A@IRSMSX108.ger.corp.intel.com>
 <1958676.MmbbGzbMYp@xps13>
In-Reply-To: <1958676.MmbbGzbMYp@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] checkpatch script
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Nov 2014 14:40:19 -0000



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Tuesday, November 25, 2014 2:29 PM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] checkpatch script
>=20
> Hi Pablo,
>=20
> 2014-11-25 13:11, De Lara Guarch, Pablo:
> > Hi Thomas,
> >
> > As we have seen the issues we have had on previous patches due to
> > checkpatch,
>=20
> No we have no issues because of checkpatch ;)
> It helps us to see some obvious errors.

I agree. With issues, I meant just confusion between using one version of c=
heckpatch or another
(mind that you are using script from 3.18-rc6, the very latest one), so it =
was good that you mentioned the version before :)
>=20
> > would it be possible to include the up-to-date script in the
> > repo? I have realized that people either do not check their patches or =
check
> > them with an old version that do not catch some errors that the latest =
one
> > does, so I think this is a problem.
>=20
> The real problem is to clearly define all the coding rules and adapt
> checkpatch to our needs.

Agree 100%.
>=20
> > Plus, I think it would be a good idea to mention it in dpdk.org/dev, as=
 this
> > is clearly a requirement for merging patches.
>=20
> Please, let's close DPDK 1.8 first.
> Then we'll have to write some documents and tools to make them approved
> after necessary discussions/debates.
OK. We will discuss it for 2.0. Thanks Thomas!
>=20
> --
> Thomas