From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 51B642E8A for ; Thu, 11 Dec 2014 20:56:57 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 11 Dec 2014 11:56:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="427905428" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by FMSMGA003.fm.intel.com with ESMTP; 11 Dec 2014 11:46:08 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.150]) by IRSMSX104.ger.corp.intel.com ([169.254.5.209]) with mapi id 14.03.0195.001; Thu, 11 Dec 2014 19:56:54 +0000 From: "De Lara Guarch, Pablo" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] vmxnet3: set txq_flags in default TX conf Thread-Index: AQHQFWVNM8x5SpwpuEqDNdmQ09nEs5yKzhwA Date: Thu, 11 Dec 2014 19:56:53 +0000 Message-ID: References: <1418317690-10151-1-git-send-email-pablo.de.lara.guarch@intel.com> In-Reply-To: <1418317690-10151-1-git-send-email-pablo.de.lara.guarch@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] vmxnet3: set txq_flags in default TX conf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Dec 2014 19:56:57 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara > Sent: Thursday, December 11, 2014 5:08 PM > To: dev@dpdk.org > Cc: root > Subject: [dpdk-dev] [PATCH] vmxnet3: set txq_flags in default TX conf >=20 > Since commit fbde27f19ab8f "get default Rx/Tx configuration from dev info= ", > a default RX/TX configuration can be used for all PMDs. > In case of vmxnet3, the whole structure was zeroed and not filled out. > The PMD does not support multi segments or offload functions, > so txq_flags should have those flags set. >=20 > Signed-off-by: root Self-NACK. Wrong signed-off. > --- > lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) >=20 > diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c > b/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c > index 963a8a5..ef0af16 100644 > --- a/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c > +++ b/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c > @@ -642,6 +642,9 @@ > vmxnet3_dev_info_get(__attribute__((unused))struct rte_eth_dev *dev, > struct rte_ > dev_info->min_rx_bufsize =3D 1518 + RTE_PKTMBUF_HEADROOM; > dev_info->max_rx_pktlen =3D 16384; /* includes CRC, cf MAXFRS > register */ > dev_info->max_mac_addrs =3D VMXNET3_MAX_MAC_ADDRS; > + > + dev_info->default_txconf.txq_flags =3D > ETH_TXQ_FLAGS_NOMULTSEGS | > + > ETH_TXQ_FLAGS_NOOFFLOADS; > } >=20 > /* return 0 means link status changed, -1 means not changed */ > -- > 1.7.4.1