From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 7D177B533 for ; Fri, 20 Feb 2015 09:19:10 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP; 20 Feb 2015 00:15:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,613,1418112000"; d="scan'208";a="457139952" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by FMSMGA003.fm.intel.com with ESMTP; 20 Feb 2015 00:03:56 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.218]) by irsmsx105.ger.corp.intel.com ([169.254.7.117]) with mapi id 14.03.0195.001; Fri, 20 Feb 2015 08:19:06 +0000 From: "De Lara Guarch, Pablo" To: Stefan Puiu , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] Fix compilation error when compiling with clang-3.4 in C++11 mode: in C++11 concatenated string literals need to have a space in between. Thread-Index: AQHQTIWOwk0KqoE7Nk6tAQm85i8H8Zz5MnvA Date: Fri, 20 Feb 2015 08:19:06 +0000 Message-ID: References: <1424379569-15851-1-git-send-email-stefan.puiu@gmail.com> <1424379569-15851-2-git-send-email-stefan.puiu@gmail.com> In-Reply-To: <1424379569-15851-2-git-send-email-stefan.puiu@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: Stefan Puiu Subject: Re: [dpdk-dev] [PATCH] Fix compilation error when compiling with clang-3.4 in C++11 mode: in C++11 concatenated string literals need to have a space in between. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Feb 2015 08:19:11 -0000 Hi Stefan, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stefan Puiu > Sent: Thursday, February 19, 2015 8:59 PM > To: dev@dpdk.org > Cc: Stefan Puiu > Subject: [dpdk-dev] [PATCH] Fix compilation error when compiling with > clang-3.4 in C++11 mode: in C++11 concatenated string literals need to ha= ve a > space in between. >=20 > From: Stefan Puiu >=20 > Sample error message: > dpdk/include/rte_pci.h:96:26: error: invalid suffix on literal; C++11 req= uires a > space between literal and identifier [-Wreserved-user-defined-literal] You forgot to include "Signed-off". Pablo > --- > lib/librte_eal/common/include/rte_pci.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/librte_eal/common/include/rte_pci.h > b/lib/librte_eal/common/include/rte_pci.h > index 66ed793..12ae5a7 100644 > --- a/lib/librte_eal/common/include/rte_pci.h > +++ b/lib/librte_eal/common/include/rte_pci.h > @@ -93,10 +93,10 @@ extern struct pci_device_list pci_device_list; /**< > Global list of PCI devices. > #define SYSFS_PCI_DEVICES "/sys/bus/pci/devices" >=20 > /** Formatting string for PCI device identifier: Ex: 0000:00:01.0 */ > -#define PCI_PRI_FMT "%.4"PRIx16":%.2"PRIx8":%.2"PRIx8".%"PRIx8 > +#define PCI_PRI_FMT "%.4" PRIx16 ":%.2" PRIx8 ":%.2" PRIx8 ".%" PRIx8 >=20 > /** Short formatting string, without domain, for PCI device: Ex: 00:01.0= */ > -#define PCI_SHORT_PRI_FMT "%.2"PRIx8":%.2"PRIx8".%"PRIx8 > +#define PCI_SHORT_PRI_FMT "%.2" PRIx8 ":%.2" PRIx8 ".%" PRIx8 >=20 > /** Nb. of values in PCI device identifier format string. */ > #define PCI_FMT_NVAL 4 > -- > 1.7.9.5