From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 8E9339AC1
 for <dev@dpdk.org>; Tue, 24 Feb 2015 20:10:59 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga101.fm.intel.com with ESMTP; 24 Feb 2015 11:10:57 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.09,640,1418112000"; d="scan'208";a="532247821"
Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31])
 by orsmga003.jf.intel.com with ESMTP; 24 Feb 2015 11:01:52 -0800
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.218]) by
 IRSMSX106.ger.corp.intel.com ([169.254.8.235]) with mapi id 14.03.0195.001;
 Tue, 24 Feb 2015 19:10:54 +0000
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Wodkowski, PawelX" <pawelx.wodkowski@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Thread-Topic: [PATCH v6 2/3] examples: introduce new l2fwd-jobstats example
Thread-Index: AQHQUFEIeNFdWQ4kAkylFlgnYEr8LZ0AKcVQ
Date: Tue, 24 Feb 2015 19:10:53 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D897272639F7@IRSMSX108.ger.corp.intel.com>
References: <1424348324-29932-1-git-send-email-pawelx.wodkowski@intel.com>
 <1424795605-2779-1-git-send-email-pawelx.wodkowski@intel.com>
 <1424795605-2779-3-git-send-email-pawelx.wodkowski@intel.com>
In-Reply-To: <1424795605-2779-3-git-send-email-pawelx.wodkowski@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v6 2/3] examples: introduce new
	l2fwd-jobstats example
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Feb 2015 19:11:00 -0000



> -----Original Message-----
> From: Wodkowski, PawelX
> Sent: Tuesday, February 24, 2015 4:33 PM
> To: dev@dpdk.org; De Lara Guarch, Pablo
> Subject: [PATCH v6 2/3] examples: introduce new l2fwd-jobstats example
>=20
> This app demonstrate usage of new rte_jobstats library.
> It is basically the orginal l2fwd with following modifications to met
> library requirements:
> - main_loop() was split into two jobs: forward job and flush job. Logic
> for those jobs is almost the same as in original application.
> - stats is moved to rte_alarm callback to not introduce overhead of
> printing.
> - stats are expanded to show rte_jobstats statistics.
> - added new parameter '-l' to automatic thousands separator.
>=20
> Comparing original l2fwd and l2fwd-jobstats apps will show approach what
> is needed to properly write own application with rte_jobstats
> measurements.
>=20
> New available statistics:
> - Total and % of fwd and flush execution time
> - management time - overhead of rte_timer + overhead of rte_jobstats
> library
> - Idle time and % of time spent waiting for fwd or flush to be ready to
> execute.
> - per job execution time and period.
>=20
> Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
> ---
>  examples/Makefile                |    1 +
>  examples/l2fwd-jobstats/Makefile |   51 ++
>  examples/l2fwd-jobstats/main.c   | 1040
> ++++++++++++++++++++++++++++++++++++++
>  mk/rte.app.mk                    |    4 +
>  4 files changed, 1096 insertions(+)
>  create mode 100644 examples/l2fwd-jobstats/Makefile
>  create mode 100644 examples/l2fwd-jobstats/main.c
>=20
> diff --git a/examples/Makefile b/examples/Makefile
> index 81f1d2f..e847ded 100644
> --- a/examples/Makefile
> +++ b/examples/Makefile
> @@ -50,6 +50,7 @@ DIRS-$(CONFIG_RTE_MBUF_REFCNT) +=3D
> ip_fragmentation
>  DIRS-$(CONFIG_RTE_MBUF_REFCNT) +=3D ipv4_multicast
>  DIRS-$(CONFIG_RTE_LIBRTE_KNI) +=3D kni
>  DIRS-y +=3D l2fwd
> +DIRS-y +=3D l2fwd-jobstats
>  DIRS-$(CONFIG_RTE_LIBRTE_IVSHMEM) +=3D l2fwd-ivshmem
>  DIRS-y +=3D l3fwd
>  DIRS-$(CONFIG_RTE_LIBRTE_ACL) +=3D l3fwd-acl
> diff --git a/examples/l2fwd-jobstats/Makefile b/examples/l2fwd-
> jobstats/Makefile
> new file mode 100644
> index 0000000..d57a0ae
> --- /dev/null
> +++ b/examples/l2fwd-jobstats/Makefile
> @@ -0,0 +1,51 @@
> +#   BSD LICENSE
> +#
> +#   Copyright(c) 2010-2015 Intel Corporation. All rights reserved.

Fix these dates. Plus, there was a conflict due to a recent commit,
modifying examples/Makefile, so make sure you rebase ;)

Thanks,
Pablo