From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id B0D529AC7 for ; Tue, 24 Feb 2015 20:17:00 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 24 Feb 2015 11:12:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,640,1418112000"; d="scan'208";a="670978354" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by fmsmga001.fm.intel.com with ESMTP; 24 Feb 2015 11:16:54 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.218]) by IRSMSX109.ger.corp.intel.com ([169.254.13.103]) with mapi id 14.03.0195.001; Tue, 24 Feb 2015 19:16:54 +0000 From: "De Lara Guarch, Pablo" To: "De Lara Guarch, Pablo" , "Wodkowski, PawelX" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v6 2/3] examples: introduce new l2fwd-jobstats example Thread-Index: AQHQUGWsWpHD0TsKQ0+fynvwIzNhqZ0AK4KA Date: Tue, 24 Feb 2015 19:16:53 +0000 Message-ID: References: <1424348324-29932-1-git-send-email-pawelx.wodkowski@intel.com> <1424795605-2779-1-git-send-email-pawelx.wodkowski@intel.com> <1424795605-2779-3-git-send-email-pawelx.wodkowski@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v6 2/3] examples: introduce new l2fwd-jobstats example X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Feb 2015 19:17:01 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Tuesday, February 24, 2015 7:11 PM > To: Wodkowski, PawelX; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 2/3] examples: introduce new l2fwd- > jobstats example >=20 >=20 >=20 > > -----Original Message----- > > From: Wodkowski, PawelX > > Sent: Tuesday, February 24, 2015 4:33 PM > > To: dev@dpdk.org; De Lara Guarch, Pablo > > Subject: [PATCH v6 2/3] examples: introduce new l2fwd-jobstats example > > > > This app demonstrate usage of new rte_jobstats library. > > It is basically the orginal l2fwd with following modifications to met > > library requirements: > > - main_loop() was split into two jobs: forward job and flush job. Logic > > for those jobs is almost the same as in original application. > > - stats is moved to rte_alarm callback to not introduce overhead of > > printing. > > - stats are expanded to show rte_jobstats statistics. > > - added new parameter '-l' to automatic thousands separator. > > > > Comparing original l2fwd and l2fwd-jobstats apps will show approach wha= t > > is needed to properly write own application with rte_jobstats > > measurements. > > > > New available statistics: > > - Total and % of fwd and flush execution time > > - management time - overhead of rte_timer + overhead of rte_jobstats > > library > > - Idle time and % of time spent waiting for fwd or flush to be ready to > > execute. > > - per job execution time and period. > > > > Signed-off-by: Pawel Wodkowski > > --- > > examples/Makefile | 1 + > > examples/l2fwd-jobstats/Makefile | 51 ++ > > examples/l2fwd-jobstats/main.c | 1040 > > ++++++++++++++++++++++++++++++++++++++ > > mk/rte.app.mk | 4 + > > 4 files changed, 1096 insertions(+) > > create mode 100644 examples/l2fwd-jobstats/Makefile > > create mode 100644 examples/l2fwd-jobstats/main.c > > > > diff --git a/examples/Makefile b/examples/Makefile > > index 81f1d2f..e847ded 100644 > > --- a/examples/Makefile > > +++ b/examples/Makefile > > @@ -50,6 +50,7 @@ DIRS-$(CONFIG_RTE_MBUF_REFCNT) +=3D > > ip_fragmentation > > DIRS-$(CONFIG_RTE_MBUF_REFCNT) +=3D ipv4_multicast > > DIRS-$(CONFIG_RTE_LIBRTE_KNI) +=3D kni > > DIRS-y +=3D l2fwd > > +DIRS-y +=3D l2fwd-jobstats > > DIRS-$(CONFIG_RTE_LIBRTE_IVSHMEM) +=3D l2fwd-ivshmem > > DIRS-y +=3D l3fwd > > DIRS-$(CONFIG_RTE_LIBRTE_ACL) +=3D l3fwd-acl > > diff --git a/examples/l2fwd-jobstats/Makefile b/examples/l2fwd- > > jobstats/Makefile > > new file mode 100644 > > index 0000000..d57a0ae > > --- /dev/null > > +++ b/examples/l2fwd-jobstats/Makefile > > @@ -0,0 +1,51 @@ > > +# BSD LICENSE > > +# > > +# Copyright(c) 2010-2015 Intel Corporation. All rights reserved. >=20 > Fix these dates. Plus, there was a conflict due to a recent commit, > modifying examples/Makefile, so make sure you rebase ;) Well, actually, I am in doubt. This is a modified version of an existing ap= p. In that case, copyright dates should contain the dates of that app, or just= the year where it was created this modified app? >=20 > Thanks, > Pablo