From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id A7F095947 for ; Fri, 6 Mar 2015 14:44:36 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 06 Mar 2015 05:44:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,352,1422950400"; d="scan'208";a="694902993" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga002.jf.intel.com with ESMTP; 06 Mar 2015 05:44:35 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.218]) by IRSMSX101.ger.corp.intel.com ([163.33.3.153]) with mapi id 14.03.0195.001; Fri, 6 Mar 2015 13:44:34 +0000 From: "De Lara Guarch, Pablo" To: Tetsuya Mukawa , "dev@dpdk.org" Thread-Topic: [PATCH] testpmd: Fix port validation code of "port stop all" command Thread-Index: AQHQVxZFxK3lSmhP7UaMOYiJCel0oZ0PeOZQ Date: Fri, 6 Mar 2015 13:44:33 +0000 Message-ID: References: <1425540606-12554-1-git-send-email-mukawa@igel.co.jp> In-Reply-To: <1425540606-12554-1-git-send-email-mukawa@igel.co.jp> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] testpmd: Fix port validation code of "port stop all" command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Mar 2015 13:44:37 -0000 > -----Original Message----- > From: Tetsuya Mukawa [mailto:mukawa@igel.co.jp] > Sent: Thursday, March 05, 2015 7:30 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo; Tetsuya Mukawa > Subject: [PATCH] testpmd: Fix port validation code of "port stop all" > command >=20 > When "port stop all" is executed, the command doesn't work as it should > because of wrong port validation. The patch fixes this issue. >=20 > Reported-by: Pablo de Lara > Signed-off-by: Tetsuya Mukawa > --- > app/test-pmd/testpmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index 61291be..bb65342 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -1484,7 +1484,7 @@ stop_port(portid_t pid) > printf("Stopping ports...\n"); >=20 > FOREACH_PORT(pi, ports) { > - if (!port_id_is_invalid(pid, DISABLED_WARN) && pid !=3D pi) > + if (pid !=3D pi && pid !=3D (portid_t)RTE_PORT_ALL) > continue; >=20 > port =3D &ports[pi]; > -- > 1.9.1 Acked-by: Pablo de Lara