From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] ethdev: fix crash with multiprocess
Date: Thu, 26 Mar 2015 17:36:42 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8972727C97A@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1427389365-18631-1-git-send-email-bruce.richardson@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson
> Sent: Thursday, March 26, 2015 5:03 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] ethdev: fix crash with multiprocess
>
> The data structure for the rx and tx callbacks is local to each process
> since it contains function pointers and cannot be shared between
> different unique binaries. However, because it is not in
> rte_eth_dev_data structure, the array is not getting initialized for
> secondary processes - neither is it getting appropriately resized if the
> number of RX/TX queues changes. This causes crashes in secondary
> processes as they dereference a null pointer in struct rte_eth_dev.
>
> This patch fixes this by introducing an upper-bound on the number of
> queues per port that can be configured, and then uses this to make the
> array statically sized, thereby avoiding the crashes.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Tested-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
next prev parent reply other threads:[~2015-03-26 17:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 17:02 Bruce Richardson
2015-03-26 17:36 ` De Lara Guarch, Pablo [this message]
2015-03-27 10:05 ` Thomas Monjalon
2015-03-27 12:27 ` Mcnamara, John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8972727C97A@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).