DPDK patches and discussions
 help / color / mirror / Atom feed
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] test: Disable strict-aliasing warnings
Date: Fri, 27 Mar 2015 10:11:14 +0000	[thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8972727CCE9@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1726796.6cYerYJHfA@xps13>



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Friday, March 27, 2015 10:01 AM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] test: Disable strict-aliasing warnings
> 
> 2015-03-27 09:29, De Lara Guarch, Pablo:
> > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > 2015-03-26 19:17, Pablo de Lara:
> > > > DPDK does not build on gcc 4.4, as it complains due to
> > > > strict-aliasing rules in virtual_pmd and link_bonding_mode4 tests,
> > > > with no errors in next gcc versions:
> > >
> > > Do you mean it's not possible to fix it in the code?
> > > You are disabling some checks which may be relevant.
> >
> > I mean it is possible to fix, but probably not worth it, considering that
> > newer gcc versions have no issues (and gcc 4.4 is from 2011).
> > I have seen that there are other libraries that disable these warnings as
> well,
> > so I assumed we could do the same here.
> 
> It is preferred to avoid doing it.

Actually, I just realized that I missed checking the gcc version, so I was disabling the warnings in all versions.
I can send a v2 with that check, so we will still take into account those warnings for newer versions,
and just ignore it in gcc 4.4.

Thanks,
Pablo

  reply	other threads:[~2015-03-27 10:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-26 19:17 Pablo de Lara
2015-03-27  8:41 ` Qiu, Michael
2015-03-27  8:57   ` De Lara Guarch, Pablo
2015-03-27  9:20 ` Thomas Monjalon
2015-03-27  9:29   ` De Lara Guarch, Pablo
2015-03-27 10:00     ` Thomas Monjalon
2015-03-27 10:11       ` De Lara Guarch, Pablo [this message]
2015-03-30 11:11         ` De Lara Guarch, Pablo
2015-03-27 10:55 ` [dpdk-dev] [PATCH v2 0/2] test: fix strict aliasing rule errors in gcc 4.4 Pawel Wodkowski
2015-03-27 10:56   ` [dpdk-dev] [PATCH v2 1/2] test: fix strict aliasing rule error in virtual pmd Pawel Wodkowski
2015-03-27 15:47     ` Stephen Hemminger
2015-03-27 10:56   ` [dpdk-dev] [PATCH v2 2/2] test: fix strict aliasing rule error in link bonding mode 4 test Pawel Wodkowski
2015-03-30 20:48   ` [dpdk-dev] [PATCH v2 0/2] test: fix strict aliasing rule errors in gcc 4.4 Thomas Monjalon
2015-03-27 15:46 ` [dpdk-dev] [PATCH] test: Disable strict-aliasing warnings Stephen Hemminger
2015-03-27 15:48   ` De Lara Guarch, Pablo
2015-03-30 11:06 ` [dpdk-dev] [PATCH v2] DPDK does not build on gcc 4.4, as it complains due to strict-aliasing rules in virtual_pmd and link_bonding_mode4 tests, with no errors in next gcc versions: Pablo de Lara
2015-03-30 20:47   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8972727CCE9@IRSMSX108.ger.corp.intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).