Re: [dpdk-dev] [PATCH] test: Disable strict-aliasing warnings

["De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>]

> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Friday, March 27, 2015 10:11 AM
> To: Thomas Monjalon
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] test: Disable strict-aliasing warnings
> 
> 
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > Sent: Friday, March 27, 2015 10:01 AM
> > To: De Lara Guarch, Pablo
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] test: Disable strict-aliasing warnings
> >
> > 2015-03-27 09:29, De Lara Guarch, Pablo:
> > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > > 2015-03-26 19:17, Pablo de Lara:
> > > > > DPDK does not build on gcc 4.4, as it complains due to
> > > > > strict-aliasing rules in virtual_pmd and link_bonding_mode4 tests,
> > > > > with no errors in next gcc versions:
> > > >
> > > > Do you mean it's not possible to fix it in the code?
> > > > You are disabling some checks which may be relevant.
> > >
> > > I mean it is possible to fix, but probably not worth it, considering that
> > > newer gcc versions have no issues (and gcc 4.4 is from 2011).
> > > I have seen that there are other libraries that disable these warnings as
> > well,
> > > so I assumed we could do the same here.
> >
> > It is preferred to avoid doing it.
> 
> Actually, I just realized that I missed checking the gcc version, so I was
> disabling the warnings in all versions.
> I can send a v2 with that check, so we will still take into account those
> warnings for newer versions,
> and just ignore it in gcc 4.4.

I just sent a v2 of this patch. Pawel also sent another fix for this issue,
but Stephen had some concerns about it, so I just sent a v2 as an alternative,
so the community can decide between the two options.

> 
> Thanks,
> Pablo