From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 1ADE75A73 for ; Mon, 30 Mar 2015 13:11:47 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 30 Mar 2015 04:11:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,493,1422950400"; d="scan'208";a="548290894" Received: from irsmsx154.ger.corp.intel.com ([163.33.192.96]) by orsmga003.jf.intel.com with ESMTP; 30 Mar 2015 04:11:46 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.49]) by IRSMSX154.ger.corp.intel.com ([163.33.192.96]) with mapi id 14.03.0224.002; Mon, 30 Mar 2015 12:11:45 +0100 From: "De Lara Guarch, Pablo" To: 'Thomas Monjalon' Thread-Topic: [dpdk-dev] [PATCH] test: Disable strict-aliasing warnings Thread-Index: AQHQZ/mOqZSonOu9tUujkVVfLNfq5p0wDnoAgAABjFCAAAnHAIAAAjSggATH4PA= Date: Mon, 30 Mar 2015 11:11:45 +0000 Message-ID: References: <1427397455-30368-1-git-send-email-pablo.de.lara.guarch@intel.com> <9913571.Sq7Gc1tDuT@xps13> <1726796.6cYerYJHfA@xps13> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "'dev@dpdk.org'" Subject: Re: [dpdk-dev] [PATCH] test: Disable strict-aliasing warnings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Mar 2015 11:11:48 -0000 > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Friday, March 27, 2015 10:11 AM > To: Thomas Monjalon > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] test: Disable strict-aliasing warnings >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > > Sent: Friday, March 27, 2015 10:01 AM > > To: De Lara Guarch, Pablo > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] test: Disable strict-aliasing warnings > > > > 2015-03-27 09:29, De Lara Guarch, Pablo: > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > 2015-03-26 19:17, Pablo de Lara: > > > > > DPDK does not build on gcc 4.4, as it complains due to > > > > > strict-aliasing rules in virtual_pmd and link_bonding_mode4 tests= , > > > > > with no errors in next gcc versions: > > > > > > > > Do you mean it's not possible to fix it in the code? > > > > You are disabling some checks which may be relevant. > > > > > > I mean it is possible to fix, but probably not worth it, considering = that > > > newer gcc versions have no issues (and gcc 4.4 is from 2011). > > > I have seen that there are other libraries that disable these warning= s as > > well, > > > so I assumed we could do the same here. > > > > It is preferred to avoid doing it. >=20 > Actually, I just realized that I missed checking the gcc version, so I wa= s > disabling the warnings in all versions. > I can send a v2 with that check, so we will still take into account those > warnings for newer versions, > and just ignore it in gcc 4.4. I just sent a v2 of this patch. Pawel also sent another fix for this issue, but Stephen had some concerns about it, so I just sent a v2 as an alternati= ve, so the community can decide between the two options. >=20 > Thanks, > Pablo