From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 402E2568A for ; Fri, 17 Jul 2015 11:06:50 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 17 Jul 2015 02:06:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,494,1432623600"; d="scan'208";a="607964938" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by orsmga003.jf.intel.com with ESMTP; 17 Jul 2015 02:06:47 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX104.ger.corp.intel.com (163.33.3.159) with Microsoft SMTP Server (TLS) id 14.3.224.2; Fri, 17 Jul 2015 10:06:29 +0100 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.201]) by IRSMSX156.ger.corp.intel.com ([169.254.3.125]) with mapi id 14.03.0224.002; Fri, 17 Jul 2015 10:06:29 +0100 From: "De Lara Guarch, Pablo" To: Tony Lu , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v7 1/7] hash: replace existing hash library with cuckoo hash implementation Thread-Index: AQHQu29EOFIwuy285UGf11xGpF0wDp3dzxKAgADIHeCAAFH/8IAAYyMAgAAHo0CAABLDMA== Date: Fri, 17 Jul 2015 09:06:28 +0000 Message-ID: References: <1436571020-16252-1-git-send-email-pablo.de.lara.guarch@intel.com> <1436573936-15956-1-git-send-email-pablo.de.lara.guarch@intel.com> <1436573936-15956-2-git-send-email-pablo.de.lara.guarch@intel.com> <001601d0bfab$6c4071e0$44c155a0$@com> <001c01d0c041$98b01c30$ca105490$@com> <000201d0c066$608af120$21a0d360$@com> In-Reply-To: <000201d0c066$608af120$21a0d360$@com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v7 1/7] hash: replace existing hash library with cuckoo hash implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jul 2015 09:06:51 -0000 Hi Tony, > -----Original Message----- > From: Tony Lu [mailto:zlu@ezchip.com] > Sent: Friday, July 17, 2015 8:58 AM > To: De Lara Guarch, Pablo; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v7 1/7] hash: replace existing hash librar= y > with cuckoo hash implementation >=20 > >-----Original Message----- > >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] > >Sent: Friday, July 17, 2015 3:35 PM > >To: Tony Lu; dev@dpdk.org > >Subject: RE: [dpdk-dev] [PATCH v7 1/7] hash: replace existing hash libra= ry > with > >cuckoo hash implementation > > > > > > > >> -----Original Message----- > >> From: Tony Lu [mailto:zlu@ezchip.com] > >> Sent: Friday, July 17, 2015 4:35 AM > >> To: De Lara Guarch, Pablo; dev@dpdk.org > >> Subject: RE: [dpdk-dev] [PATCH v7 1/7] hash: replace existing hash > >> library with cuckoo hash implementation > >> > >> Hi, Pablo > >> > >> >-----Original Message----- > >> >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.guarch@intel.com] > >> >Sent: Friday, July 17, 2015 4:42 AM > >> >To: Tony Lu; dev@dpdk.org > >> >Subject: RE: [dpdk-dev] [PATCH v7 1/7] hash: replace existing hash > >> >library > >> with > >> >cuckoo hash implementation > >> > > >> >Hi Tony, > >> > > >> >> -----Original Message----- > >> >> From: Tony Lu [mailto:zlu@ezchip.com] > >> >> Sent: Thursday, July 16, 2015 10:40 AM > >> >> To: De Lara Guarch, Pablo; dev@dpdk.org > >> >> Subject: RE: [dpdk-dev] [PATCH v7 1/7] hash: replace existing hash > >> >> library with cuckoo hash implementation > >> >> > >> >> >diff --git a/lib/librte_hash/rte_cuckoo_hash.c > >> >> b/lib/librte_hash/rte_cuckoo_hash.c > >> >> >new file mode 100644 > >> >> >index 0000000..50e3acd > >> >> >--- /dev/null > >> >> >+++ b/lib/librte_hash/rte_cuckoo_hash.c > >> >> >@@ -0,0 +1,1027 @@ > >> >> ... > >> >> >+ > >> >> >+/* Functions to compare multiple of 16 byte keys (up to 128 > >> >> >+bytes) */ static int rte_hash_k16_cmp_eq(const void *key1, const > >> >> >+void *key2, size_t key_len > >> >> >__rte_unused) > >> >> >+{ > >> >> >+ const __m128i k1 =3D _mm_loadu_si128((const __m128i *) > key1); > >> >> >+ const __m128i k2 =3D _mm_loadu_si128((const __m128i *) > key2); > >> >> >+ const __m128i x =3D _mm_xor_si128(k1, k2); > >> >> >+ > >> >> >+ return !_mm_test_all_zeros(x, x); } > >> >> ... > >> >> > >> >> When compiling the latest dev DPDK for non-x86 arch, it fails on > >> >> the above code, as the SSE is x86 specific defined in > >> >> . Is it possible to replace this function with platfo= rm > >independent code? > >> > > >> >Thanks for spotting this. I just sent a patch that should fix the > problem. > >> >Can you check if it works? > >> > >> Thanks for your quick response, but __m128i and all the _mm_ related > >> functions are X86 specific defined in . This header file > >> is only available in X86 compiler library, but no-X86 archs do not > >> have this file. So if we can replace all the X86 specific code in the > >> above function, that would be great. > >> > >With the patch that I sent, if you are compiling for a non-x86 arch, you > should > >not have any problem, since all that code will only be used if using x86 > arch. > >Have you tried compiling DPDK with the patch? >=20 > Yes, I have built the DPDK with your patch, and got the following errors. > This is > because there are no __m128i, _mm_loadu_si128(), _mm_cmpeq_epi32() > and > _mm_movemask_epi8() on no-X86 arches. >=20 > =3D=3D Build lib/librte_hash > CC rte_cuckoo_hash.o > /u/zlu.bjg/git/dpdk.org/lib/librte_hash/rte_cuckoo_hash.c: In function > 'rte_hash_k16_cmp_eq': > /u/zlu.bjg/git/dpdk.org/lib/librte_hash/rte_cuckoo_hash.c:1126: error: > expected '=3D', ',', ';', 'asm' or '__attribute__' before 'k1' > /u/zlu.bjg/git/dpdk.org/lib/librte_hash/rte_cuckoo_hash.c:1126: error: 'k= 1' > undeclared (first use in this function) > /u/zlu.bjg/git/dpdk.org/lib/librte_hash/rte_cuckoo_hash.c:1126: error: (E= ach > undeclared identifier is reported only once > /u/zlu.bjg/git/dpdk.org/lib/librte_hash/rte_cuckoo_hash.c:1126: error: fo= r > each function it appears in.) > /u/zlu.bjg/git/dpdk.org/lib/librte_hash/rte_cuckoo_hash.c:1126: warning: > implicit declaration of function '_mm_loadu_si128' > /u/zlu.bjg/git/dpdk.org/lib/librte_hash/rte_cuckoo_hash.c:1126: warning: > nested extern declaration of '_mm_loadu_si128' > /u/zlu.bjg/git/dpdk.org/lib/librte_hash/rte_cuckoo_hash.c:1126: error: > expected ')' before '__m128i' > /u/zlu.bjg/git/dpdk.org/lib/librte_hash/rte_cuckoo_hash.c:1126: warning: > type defaults to 'int' in declaration of 'type name' > /u/zlu.bjg/git/dpdk.org/lib/librte_hash/rte_cuckoo_hash.c:1126: warning: > cast from pointer to integer of different size > /u/zlu.bjg/git/dpdk.org/lib/librte_hash/rte_cuckoo_hash.c:1127: error: > expected '=3D', ',', ';', 'asm' or '__attribute__' before 'k2' > /u/zlu.bjg/git/dpdk.org/lib/librte_hash/rte_cuckoo_hash.c:1127: error: 'k= 2' > undeclared (first use in this function) > /u/zlu.bjg/git/dpdk.org/lib/librte_hash/rte_cuckoo_hash.c:1127: error: > expected ')' before '__m128i' > /u/zlu.bjg/git/dpdk.org/lib/librte_hash/rte_cuckoo_hash.c:1127: warning: > type defaults to 'int' in declaration of 'type name' > /u/zlu.bjg/git/dpdk.org/lib/librte_hash/rte_cuckoo_hash.c:1127: warning: > cast from pointer to integer of different size > /u/zlu.bjg/git/dpdk.org/lib/librte_hash/rte_cuckoo_hash.c:1133: error: > expected '=3D', ',', ';', 'asm' or '__attribute__' before 'x' > /u/zlu.bjg/git/dpdk.org/lib/librte_hash/rte_cuckoo_hash.c:1133: error: 'x= ' > undeclared (first use in this function) > /u/zlu.bjg/git/dpdk.org/lib/librte_hash/rte_cuckoo_hash.c:1133: warning: > implicit declaration of function '_mm_cmpeq_epi32' > /u/zlu.bjg/git/dpdk.org/lib/librte_hash/rte_cuckoo_hash.c:1133: warning: > nested extern declaration of '_mm_cmpeq_epi32' > /u/zlu.bjg/git/dpdk.org/lib/librte_hash/rte_cuckoo_hash.c:1135: warning: > implicit declaration of function '_mm_movemask_epi8' > /u/zlu.bjg/git/dpdk.org/lib/librte_hash/rte_cuckoo_hash.c:1135: warning: > nested extern declaration of '_mm_movemask_epi8' > make[3]: *** [rte_cuckoo_hash.o] Error 1 > make[2]: *** [librte_hash] Error 2 > make[1]: *** [lib] Error 2 > make: *** [all] Error 2 Looking at the snippet, I would say the patch has not been applied (did you apply the patch hash: "fix compilation for non-x86 systems"?), because looking at the lines where it is failing, they are the old lines in= rte_cuckoo_hash.c, which have been moved to another file (and should not be included for you). Pablo >=20 > Thanks > -Tony >=20 > >Pablo > > > >> Thanks > >> -Tony > >> > >> > >> >Thanks, > >> >Pablo > >> >> > >> >> Thanks > >> >> -Zhigang Lu > >> >=20