From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 419059E5 for ; Fri, 7 Aug 2015 11:02:03 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 07 Aug 2015 02:02:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,629,1432623600"; d="scan'208";a="744018775" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by orsmga001.jf.intel.com with ESMTP; 07 Aug 2015 02:02:01 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.22]) by IRSMSX103.ger.corp.intel.com ([169.254.3.149]) with mapi id 14.03.0224.002; Fri, 7 Aug 2015 10:02:00 +0100 From: "De Lara Guarch, Pablo" To: Sergey Balabanov , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] bonding: 8023ad: fix incorrect typecast of socket Thread-Index: AQHQz4V74DRFajH1xUCFwQyB3P3Vcp4AQBbg Date: Fri, 7 Aug 2015 09:01:59 +0000 Message-ID: References: <1438782512-8364-1-git-send-email-balabanovsv@ecotelecom.ru> In-Reply-To: <1438782512-8364-1-git-send-email-balabanovsv@ecotelecom.ru> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] bonding: 8023ad: fix incorrect typecast of socket X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Aug 2015 09:02:03 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sergey Balabanov > Sent: Wednesday, August 05, 2015 2:49 PM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] bonding: 8023ad: fix incorrect typecast of > socket >=20 > On slave activation in LACP (8023AD) SOCKET_ANY_ID (which is -1) > is being casted to unsigned char and then to signed int. > The result is that socket_id has value of 255, not -1. > This results to memory allocation failure. > --- > drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c > b/drivers/net/bonding/rte_eth_bond_8023ad.c > index 97a828e..c0f0b99 100644 > --- a/drivers/net/bonding/rte_eth_bond_8023ad.c > +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c > @@ -849,7 +849,7 @@ bond_mode_8023ad_activate_slave(struct > rte_eth_dev *bond_dev, uint8_t slave_id) > }; >=20 > char mem_name[RTE_ETH_NAME_MAX_LEN]; > - uint8_t socket_id; > + int socket_id; > unsigned element_size; >=20 > /* Given slave mus not be in active list */ > -- > 2.1.4 Acked-by: Pablo de Lara You forgot to sign off the patch, can you send a v2 with it? You can includ= e my ack. Thanks! Pablo