From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 5186C255
 for <dev@dpdk.org>; Fri,  7 Aug 2015 11:38:14 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga103.fm.intel.com with ESMTP; 07 Aug 2015 02:38:13 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.15,629,1432623600"; d="scan'208";a="621074746"
Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75])
 by orsmga003.jf.intel.com with ESMTP; 07 Aug 2015 02:38:13 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.22]) by
 IRSMSX153.ger.corp.intel.com ([169.254.9.59]) with mapi id 14.03.0224.002;
 Fri, 7 Aug 2015 10:38:11 +0100
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Sergey Balabanov <balabanovsv@ecotelecom.ru>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [PATCH v2] bonding: 8023ad: fix incorrect typecast of socket
Thread-Index: AQHQ0PQlqloeda6xNk2vAx1Dl6RcDp4ARy0w
Date: Fri, 7 Aug 2015 09:38:10 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C7D9643@IRSMSX108.ger.corp.intel.com>
References: <bonding: 8023ad: fix incorrect typecast of socket>
 <1438939998-30041-1-git-send-email-balabanovsv@ecotelecom.ru>
In-Reply-To: <1438939998-30041-1-git-send-email-balabanovsv@ecotelecom.ru>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2] bonding: 8023ad: fix incorrect typecast
	of socket
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Aug 2015 09:38:15 -0000



> -----Original Message-----
> From: Sergey Balabanov [mailto:balabanovsv@ecotelecom.ru]
> Sent: Friday, August 07, 2015 10:33 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo; Sergey Balabanov
> Subject: [PATCH v2] bonding: 8023ad: fix incorrect typecast of socket
>=20
> On slave activation in LACP (8023AD) SOCKET_ANY_ID (which is -1)
> is being casted to unsigned char and then to signed int.
> The result is that socket_id has value of 255, not -1.
> This results to memory allocation failure.
>=20
> Signed-off-by: Sergey Balabanov <balabanovsv@ecotelecom.ru>

Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>