From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 92D7AFE5
 for <dev@dpdk.org>; Sun,  9 Aug 2015 12:28:42 +0200 (CEST)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga103.jf.intel.com with ESMTP; 09 Aug 2015 03:28:42 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.15,639,1432623600"; d="scan'208";a="745070259"
Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28])
 by orsmga001.jf.intel.com with ESMTP; 09 Aug 2015 03:28:41 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.22]) by
 irsmsx105.ger.corp.intel.com ([169.254.7.223]) with mapi id 14.03.0224.002;
 Sun, 9 Aug 2015 11:28:39 +0100
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH] examples/l3fwd: fix compilation issue when
 using exact-match
Thread-Index: AQHQ0omPYJeVAjC3t0C48Oyha3LLuJ4DdxCg
Date: Sun, 9 Aug 2015 10:28:39 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C7D9E55@IRSMSX108.ger.corp.intel.com>
References: <1438938514-10304-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <8423022.rae0ANLxGt@xps13>
In-Reply-To: <8423022.rae0ANLxGt@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fix compilation issue when
 using exact-match
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 09 Aug 2015 10:28:43 -0000

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Sunday, August 09, 2015 10:54 AM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fix compilation issue whe=
n
> using exact-match
>=20
> Hi Pablo,
>=20
> 2015-08-07 10:08, Pablo de Lara:
> > L3fwd was trying to use an inexistent function "simple_ipv6_fwd_4pkts",
> > instead it should be "simple_ipv6_fwd_8pkts".
> >
> > Fixes: 80fcb4d4 ("examples/l3fwd: increase lookup burst size to 8")
>=20
> There are 3 things wrong here.
>=20
> 1/ We must absolutely avoid compile-time paths:
> 	#if (ENABLE_MULTI_BUFFER_OPTIMIZE =3D=3D 1)
> 	#if (APP_LOOKUP_METHOD =3D=3D APP_LOOKUP_EXACT_MATCH)
> It makes test coverage too hard to track.
>=20
> 2/ When replacing a function, grepping it is a must have.
> -simple_ipv6_fwd_4pkts(struct rte_mbuf* m[4], uint8_t portid, struct
> lcore_conf *qconf)
> +simple_ipv6_fwd_8pkts(struct rte_mbuf *m[8], uint8_t portid, struct
> lcore_conf *qconf)
> So this change would be straight forward:
> > -
> 	simple_ipv6_fwd_4pkts(&pkts_burst[j],
> > +
> 	simple_ipv6_fwd_8pkts(&pkts_burst[j],
>=20
> 3/ The above commit makes also this wrong replacement:
> -                                               simple_ipv4_fwd_4pkts(&pk=
ts_burst[j],
> +                                               simple_ipv8_fwd_4pkts(&pk=
ts_burst[j],
> It is still not fixed.
>=20
> Please send a v2 for this last typo. Thanks

Thanks for spotting it, v2 on the way!

Pablo