From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 9E7EB377E for ; Fri, 25 Sep 2015 09:19:33 +0200 (CEST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 25 Sep 2015 00:19:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,585,1437462000"; d="scan'208";a="652016328" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga003.jf.intel.com with ESMTP; 25 Sep 2015 00:19:25 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.216]) by IRSMSX107.ger.corp.intel.com ([169.254.10.252]) with mapi id 14.03.0248.002; Fri, 25 Sep 2015 08:19:24 +0100 From: "De Lara Guarch, Pablo" To: "He, Shaopeng" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 4/5] l3fwd-power: fix a memory leak for non-ip packet Thread-Index: AQHQ91Re3NjiYKe3IkOCDJjVIoZ7G55M1gpw Date: Fri, 25 Sep 2015 07:19:24 +0000 Message-ID: References: <1443159425-32502-1-git-send-email-shaopeng.he@intel.com> <1443159425-32502-5-git-send-email-shaopeng.he@intel.com> In-Reply-To: <1443159425-32502-5-git-send-email-shaopeng.he@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 4/5] l3fwd-power: fix a memory leak for non-ip packet X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Sep 2015 07:19:34 -0000 Hi Shaopeng, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Shaopeng He > Sent: Friday, September 25, 2015 6:37 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 4/5] l3fwd-power: fix a memory leak for non-ip > packet >=20 > Previous l3fwd-power only processes IP and IPv6 packet, other > packet's mbuf is not released, and causes a memory leak. > This patch fixes this issue. Is this patch related to the rest of the patchset? Something where fm10k is= involved? Because it does not look like. Thanks, Pablo >=20 > Signed-off-by: Shaopeng He > --- > examples/l3fwd-power/main.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c > index 8bb88ce..ecdff73 100644 > --- a/examples/l3fwd-power/main.c > +++ b/examples/l3fwd-power/main.c > @@ -714,7 +714,8 @@ l3fwd_simple_forward(struct rte_mbuf *m, uint8_t > portid, > /* We don't currently handle IPv6 packets in LPM mode. */ > rte_pktmbuf_free(m); > #endif > - } > + } else > + rte_pktmbuf_free(m); >=20 > } >=20 > -- > 1.9.3