DPDK patches and discussions
 help / color / mirror / Atom feed
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Jiuling Bie <bie.jiuling@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [testpmd] enable lsc to avoid TX stall, TX stall happened in following sequence start show port info 0
Date: Tue, 13 Oct 2015 09:07:00 +0000	[thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C833CDD@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1444236843-3000-1-git-send-email-bie.jiuling@gmail.com>

Hi Jiuling,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jiuling Bie
> Sent: Wednesday, October 07, 2015 5:54 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [testpmd] enable lsc to avoid TX stall, TX stall happened
> in following sequence start show port info 0
> 
> ---
>  app/test-pmd/testpmd.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index 386bf84..45adefa 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -1779,6 +1779,7 @@ init_port_config(void)
>  		port = &ports[pid];
>  		port->dev_conf.rxmode = rx_mode;
>  		port->dev_conf.fdir_conf = fdir_conf;
> +		port->dev_conf.intr_conf.lsc = 1;
>  		if (nb_rxq > 1) {
>  			port->dev_conf.rx_adv_conf.rss_conf.rss_key =
> NULL;
>  			port->dev_conf.rx_adv_conf.rss_conf.rss_hf =
> rss_hf;
> --
> 1.9.1

Several things about your patch:
-  It looks like this is your first patch (plus the other one you sent a few minutes later): take a look at http://dpdk.org/dev
- You forgot to sign off your patches (use --signoff with git commit)
- The title of this patch is too long, shorten it and include more information in the body of the commit message.
- I don't know what this patch is trying to solve exactly. It looks like you are saying that there is a bug
  that makes TX stop when you run the following commands:
   testpmd> start
   testpmd> show port info 0

I don't see such bug, could you explain better the steps to reproduce the issue?

Thanks,
Pablo

  reply	other threads:[~2015-10-13  9:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-07 16:54 Jiuling Bie
2015-10-13  9:07 ` De Lara Guarch, Pablo [this message]
2015-10-13 15:32   ` Jiuling Bie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8973C833CDD@IRSMSX108.ger.corp.intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=bie.jiuling@gmail.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).