From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id F02918D3D
 for <dev@dpdk.org>; Mon, 26 Oct 2015 21:37:19 +0100 (CET)
Received: from orsmga002.jf.intel.com ([10.7.209.21])
 by fmsmga101.fm.intel.com with ESMTP; 26 Oct 2015 13:37:18 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,201,1444719600"; d="scan'208";a="835536173"
Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153])
 by orsmga002.jf.intel.com with ESMTP; 26 Oct 2015 13:37:18 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.138]) by
 IRSMSX101.ger.corp.intel.com ([169.254.1.33]) with mapi id 14.03.0248.002;
 Mon, 26 Oct 2015 20:37:17 +0000
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: add engine for UDP echo server
 support
Thread-Index: AQHRDqJ4poH7SG1zpEGSiuOxRnLhPZ5+N8Ug
Date: Mon, 26 Oct 2015 20:37:16 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C83C589@IRSMSX108.ger.corp.intel.com>
References: <1441387057-31525-1-git-send-email-cascardo@redhat.com>
 <3274805.kg8Ya5y6Ui@xps13>
In-Reply-To: <3274805.kg8Ya5y6Ui@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add engine for UDP echo server
 support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 26 Oct 2015 20:37:20 -0000

Hi,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Saturday, October 24, 2015 10:24 PM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org; Thadeu Lima de Souza Cascardo
> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add engine for UDP echo
> server support
>=20
> Pablo, opinion?
> Is the UDP echo eligible in testpmd to ease some tests?
>=20
> 2015-09-04 14:17, Thadeu Lima de Souza Cascardo:
> > Adapt the ICMP echo code to reply to UDP echo requests on port 7. The
> testpmd
> > forward engine udpecho is used for that.
> >
> > Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com>

Sorry I missed this patch. Patch looks fine, but in my opinion,
it would be better to rename icmpecho to just echo,
and integrate UDP and TCP, with ICMP, as I think there is no need
to increase the number of forwarding modes for something so similar.

Pablo