From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 25C0A8D89 for ; Mon, 26 Oct 2015 21:41:55 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP; 26 Oct 2015 13:41:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,201,1444719600"; d="scan'208";a="819931748" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by fmsmga001.fm.intel.com with ESMTP; 26 Oct 2015 13:41:54 -0700 Received: from irsmsx112.ger.corp.intel.com (10.108.20.5) by irsmsx105.ger.corp.intel.com (163.33.3.28) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 26 Oct 2015 20:41:53 +0000 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.138]) by irsmsx112.ger.corp.intel.com ([169.254.1.218]) with mapi id 14.03.0248.002; Mon, 26 Oct 2015 20:41:53 +0000 From: "De Lara Guarch, Pablo" To: "De Lara Guarch, Pablo" , Thomas Monjalon Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: add engine for UDP echo server support Thread-Index: AQHRDqJ4poH7SG1zpEGSiuOxRnLhPZ5+N8UggAAICvA= Date: Mon, 26 Oct 2015 20:41:52 +0000 Message-ID: References: <1441387057-31525-1-git-send-email-cascardo@redhat.com> <3274805.kg8Ya5y6Ui@xps13> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add engine for UDP echo server support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Oct 2015 20:41:56 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of De Lara Guarch, > Pablo > Sent: Monday, October 26, 2015 8:37 PM > To: Thomas Monjalon > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add engine for UDP echo > server support >=20 > Hi, >=20 > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Saturday, October 24, 2015 10:24 PM > > To: De Lara Guarch, Pablo > > Cc: dev@dpdk.org; Thadeu Lima de Souza Cascardo > > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add engine for UDP echo > > server support > > > > Pablo, opinion? > > Is the UDP echo eligible in testpmd to ease some tests? > > > > 2015-09-04 14:17, Thadeu Lima de Souza Cascardo: > > > Adapt the ICMP echo code to reply to UDP echo requests on port 7. The > > testpmd > > > forward engine udpecho is used for that. > > > > > > Signed-off-by: Thadeu Lima de Souza Cascardo >=20 > Sorry I missed this patch. Patch looks fine, but in my opinion, > it would be better to rename icmpecho to just echo, > and integrate UDP and TCP, with ICMP, as I think there is no need > to increase the number of forwarding modes for something so similar. >=20 Actually, I forgot to say that patch does not compile at least with gcc 5.1= . Variables icmp_h and udp_h in reply_to_echo_rqsts() have to be initialized. > Pablo