From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id D7BBE5A76
 for <dev@dpdk.org>; Tue, 27 Oct 2015 08:55:27 +0100 (CET)
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga103.fm.intel.com with ESMTP; 27 Oct 2015 00:55:06 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,203,1444719600"; d="scan'208";a="836354038"
Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25])
 by fmsmga002.fm.intel.com with ESMTP; 27 Oct 2015 00:55:02 -0700
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.138]) by
 irsmsx110.ger.corp.intel.com ([169.254.15.151]) with mapi id 14.03.0248.002;
 Tue, 27 Oct 2015 07:55:01 +0000
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Sun, Xutao" <xutao.sun@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH v2] examples/vmdq: Fix the core dump issue
 when	mem_pool is more than 34
Thread-Index: AQHREHX0IPTcCbpa8EiSlo1vE4TIPp5++EjQ
Date: Tue, 27 Oct 2015 07:55:00 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C83C7C4@IRSMSX108.ger.corp.intel.com>
References: <1444721365-1065-1-git-send-email-xutao.sun@intel.com>
 <1445922658-4955-1-git-send-email-xutao.sun@intel.com>
In-Reply-To: <1445922658-4955-1-git-send-email-xutao.sun@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.181]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v2] examples/vmdq: Fix the core dump issue
 when	mem_pool is more than 34
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Oct 2015 07:55:28 -0000

Hi Xutao,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xutao Sun
> Sent: Tuesday, October 27, 2015 5:11 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] examples/vmdq: Fix the core dump issue
> when mem_pool is more than 34
>=20
> Macro MAX_QUEUES was defined to 128, only allow 16 vmdq_pools in
> theory.
> When running vmdq_app with more than 34 vmdq_pools, it will cause the
> core_dump issue.
> Change MAX_QUEUES to 1024 will solve this issue.
>=20
> Signed-off-by: Xutao Sun <xutao.sun@intel.com>
> ---
> v2:
>  - rectify the NUM_MBUFS_PER_PORT since MAX_QUEUES has been
> changed
>=20
>  examples/vmdq/main.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>=20
> diff --git a/examples/vmdq/main.c b/examples/vmdq/main.c
> index a142d49..bba5164 100644
> --- a/examples/vmdq/main.c
> +++ b/examples/vmdq/main.c
> @@ -69,12 +69,13 @@
>  #include <rte_mbuf.h>
>  #include <rte_memcpy.h>
>=20
> -#define MAX_QUEUES 128
> +#define MAX_QUEUES 1024
>  /*
>   * For 10 GbE, 128 queues require roughly
>   * 128*512 (RX/TX_queue_nb * RX/TX_ring_descriptors_nb) per port.
>   */
> -#define NUM_MBUFS_PER_PORT (128*512)
> +#define NUM_MBUFS_PER_PORT (MAX_QUEUES *
> RTE_MAX(RTE_TEST_RX_DESC_DEFAULT, \
> +
> 	RTE_TEST_TX_DESC_DEFAULT))
>  #define MBUF_CACHE_SIZE 64
>=20
>  #define MAX_PKT_BURST 32
> --
> 1.9.3

Please, change the comment above, as you have change code related to it,
i.e. it is not 128*512 anymore.

Pablo