From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] e1000: mark rxq with RTE_SET_USED
Date: Wed, 28 Oct 2015 16:18:29 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C83DE28@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1446048480-9139-1-git-send-email-harry.van.haaren@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Harry van Haaren
> Sent: Wednesday, October 28, 2015 4:08 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] e1000: mark rxq with RTE_SET_USED
>
> This patch marks rxq with RTE_SET_USED in
> rx_desc_hlen_type_rss_to_pkt_flags(), when
> ieee1588 is disabled. Previously a compilation
> error occurred on unused-parameter.
>
> Fixes: 1ce6591e238a ("igb: fix ieee1588 frame identification in i210")
>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> ---
>
> v2: Fixed Fixes line (the irony)
>
> drivers/net/e1000/igb_rxtx.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c
> index 66bc3f0..d734a19 100644
> --- a/drivers/net/e1000/igb_rxtx.c
> +++ b/drivers/net/e1000/igb_rxtx.c
> @@ -732,6 +732,8 @@ rx_desc_hlen_type_rss_to_pkt_flags(struct
> igb_rx_queue *rxq, uint32_t hl_tp_rs)
> pkt_flags |= ip_pkt_etqf_map[(hl_tp_rs >> 12) & 0x07];
> else
> pkt_flags |= ip_pkt_etqf_map[(hl_tp_rs >> 4) & 0x07];
> +#else
> + RTE_SET_USED(rxq);
> #endif
>
> return pkt_flags;
> --
> 1.9.1
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
next prev parent reply other threads:[~2015-10-28 16:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 16:08 Harry van Haaren
2015-10-28 16:18 ` De Lara Guarch, Pablo [this message]
2015-10-28 17:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8973C83DE28@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).