From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 9D79EDE6 for ; Thu, 29 Oct 2015 08:53:56 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 29 Oct 2015 00:53:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,213,1444719600"; d="scan'208";a="822091038" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by fmsmga001.fm.intel.com with ESMTP; 29 Oct 2015 00:53:54 -0700 Received: from irsmsx155.ger.corp.intel.com (163.33.192.3) by IRSMSX152.ger.corp.intel.com (163.33.192.66) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 29 Oct 2015 07:53:53 +0000 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.138]) by irsmsx155.ger.corp.intel.com ([169.254.14.242]) with mapi id 14.03.0248.002; Thu, 29 Oct 2015 07:53:53 +0000 From: "De Lara Guarch, Pablo" To: "Sun, Xutao" , "dev@dpdk.org" Thread-Topic: [PATCH v3] examples/vmdq: Fix the core dump issue when mem_pool is more than 34 Thread-Index: AQHREJW7OgysmI2iZkicxLGizMTXL56CHHgA Date: Thu, 29 Oct 2015 07:53:52 +0000 Message-ID: References: <1445922658-4955-1-git-send-email-xutao.sun@intel.com> <1445936313-31782-1-git-send-email-xutao.sun@intel.com> In-Reply-To: <1445936313-31782-1-git-send-email-xutao.sun@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] examples/vmdq: Fix the core dump issue when mem_pool is more than 34 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2015 07:53:57 -0000 > -----Original Message----- > From: Sun, Xutao > Sent: Tuesday, October 27, 2015 8:59 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo; Wu, Jingjing; Zhang, Helin; Sun, Xutao > Subject: [PATCH v3] examples/vmdq: Fix the core dump issue when > mem_pool is more than 34 >=20 > Macro MAX_QUEUES was defined to 128, only allow 16 vmdq_pools in > theory. > When running vmdq_app with more than 34 vmdq_pools, it will cause the > core_dump issue. > Change MAX_QUEUES to 1024 will solve this issue. >=20 > Signed-off-by: Xutao Sun > --- > v2: > - Rectify the NUM_MBUFS_PER_PORT since MAX_QUEUES has been > changed >=20 > v3: > - Change the comments above the relevant code. >=20 > examples/vmdq/main.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) >=20 > diff --git a/examples/vmdq/main.c b/examples/vmdq/main.c > index a142d49..178af2f 100644 > --- a/examples/vmdq/main.c > +++ b/examples/vmdq/main.c > @@ -69,12 +69,13 @@ > #include > #include >=20 > -#define MAX_QUEUES 128 > +#define MAX_QUEUES 1024 > /* > - * For 10 GbE, 128 queues require roughly > - * 128*512 (RX/TX_queue_nb * RX/TX_ring_descriptors_nb) per port. > + * 1024 queues require to meet the needs of a large number of > vmdq_pools. > + * (RX/TX_queue_nb * RX/TX_ring_descriptors_nb) per port. > */ > -#define NUM_MBUFS_PER_PORT (128*512) > +#define NUM_MBUFS_PER_PORT (MAX_QUEUES * > RTE_MAX(RTE_TEST_RX_DESC_DEFAULT, \ > + > RTE_TEST_TX_DESC_DEFAULT)) > #define MBUF_CACHE_SIZE 64 >=20 > #define MAX_PKT_BURST 32 > -- > 1.9.3 Acked-by: Pablo de Lara