DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] librte: fix igb_uio's access to pci_dev->msi_list for kernels >= 4.3
@ 2015-10-28 14:24 David Hunt
  2015-10-30 10:57 ` De Lara Guarch, Pablo
  0 siblings, 1 reply; 2+ messages in thread
From: David Hunt @ 2015-10-28 14:24 UTC (permalink / raw)
  To: dev

Fix to take this change into account: https://lkml.org/lkml/2015/7/9/101
Has been applied to Kernel 4.3.0-rc6

Signed-off-by: David Hunt <david.hunt@intel.com>
---
 lib/librte_eal/linuxapp/igb_uio/igb_uio.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
index 865a276..3bda5d2 100644
--- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
+++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
@@ -254,8 +254,13 @@ igbuio_pci_irqcontrol(struct uio_info *info, s32 irq_state)
 	else if (udev->mode == RTE_INTR_MODE_MSIX) {
 		struct msi_desc *desc;
 
+#if (LINUX_VERSION_CODE < KERNEL_VERSION(4, 3, 0))
 		list_for_each_entry(desc, &pdev->msi_list, list)
 			igbuio_msix_mask_irq(desc, irq_state);
+#else
+		list_for_each_entry(desc, &pdev->dev.msi_list, list)
+			igbuio_msix_mask_irq(desc, irq_state);
+#endif
 	}
 	pci_cfg_access_unlock(pdev);
 
-- 
1.7.4.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] librte: fix igb_uio's access to pci_dev->msi_list for kernels >= 4.3
  2015-10-28 14:24 [dpdk-dev] [PATCH] librte: fix igb_uio's access to pci_dev->msi_list for kernels >= 4.3 David Hunt
@ 2015-10-30 10:57 ` De Lara Guarch, Pablo
  0 siblings, 0 replies; 2+ messages in thread
From: De Lara Guarch, Pablo @ 2015-10-30 10:57 UTC (permalink / raw)
  To: Hunt, David, dev

Hi Dave,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Hunt
> Sent: Wednesday, October 28, 2015 2:25 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] librte: fix igb_uio's access to pci_dev->msi_list
> for kernels >= 4.3
> 
> Fix to take this change into account: https://lkml.org/lkml/2015/7/9/101
> Has been applied to Kernel 4.3.0-rc6
> 
> Signed-off-by: David Hunt <david.hunt@intel.com>
> ---

Fix works, but could you modify the commit title? igb_uio: fix....
Also, in the past we have included the commit id on the Linux repository,
which is:

Linux: 4a7cc831 ("genirq/MSI: Move msi_list from struct pci_dev to struct device")

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-10-30 10:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-28 14:24 [dpdk-dev] [PATCH] librte: fix igb_uio's access to pci_dev->msi_list for kernels >= 4.3 David Hunt
2015-10-30 10:57 ` De Lara Guarch, Pablo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).