From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id F1F40532D for ; Mon, 9 Nov 2015 14:38:49 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 09 Nov 2015 05:38:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,266,1444719600"; d="scan'208";a="815374197" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga001.jf.intel.com with ESMTP; 09 Nov 2015 05:38:47 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.23]) by irsmsx105.ger.corp.intel.com ([169.254.7.203]) with mapi id 14.03.0248.002; Mon, 9 Nov 2015 13:38:46 +0000 From: "De Lara Guarch, Pablo" To: "Ananyev, Konstantin" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCHv5 1/2] testpmd: add ability to split outgoing packets Thread-Index: AQHRGtAGcUGnIw35dEGqEFZEhmr+5Z6TsQKA Date: Mon, 9 Nov 2015 13:38:45 +0000 Message-ID: References: <1447060816-9923-1-git-send-email-konstantin.ananyev@intel.com> <1447060816-9923-2-git-send-email-konstantin.ananyev@intel.com> In-Reply-To: <1447060816-9923-2-git-send-email-konstantin.ananyev@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCHv5 1/2] testpmd: add ability to split outgoing packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Nov 2015 13:38:50 -0000 Hi Konstantin, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Konstantin > Ananyev > Sent: Monday, November 09, 2015 9:20 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCHv5 1/2] testpmd: add ability to split outgoing > packets >=20 > For CSUM forwarding mode add ability to copy & split outgoing packet > into the new mbuf that consists of multiple segments. > For TXONLY and CSUM forwarding modes add ability to make number of > segments in the outgoing packet to vary on a per packet basis. > Number of segments and size of each segment is controlled by > 'set txpkts' command. > Split policy is controlled by 'set txsplit' command. > Possible values are: on | off | rand. > Tha allows to increase test coverage for TX PMD codepaths. >=20 > Signed-off-by: Konstantin Ananyev > --- > app/test-pmd/cmdline.c | 57 +++++++++- > app/test-pmd/config.c | 61 +++++++++++ > app/test-pmd/csumonly.c | 163 > +++++++++++++++++++++++++++- > app/test-pmd/testpmd.c | 3 + > app/test-pmd/testpmd.h | 10 ++ > app/test-pmd/txonly.c | 13 ++- > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 11 +- > 7 files changed, 309 insertions(+), 9 deletions(-) >=20 [...] > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > index 4fb1e0b..4608b3f 100644 > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -211,7 +211,7 @@ show config > Displays the configuration of the application. > The configuration comes from the command-line, the runtime or the > application defaults:: >=20 > - testpmd> show config (rxtx|cores|fwd) > + testpmd> show config (rxtx|cores|fwd|txpkts) >=20 > The available information categories are: >=20 > @@ -221,6 +221,8 @@ The available information categories are: >=20 > * ``fwd``: Packet forwarding configuration. >=20 > +* ``txpkts``: Packets to TX configuration. > + > For example: >=20 > .. code-block:: console > @@ -396,6 +398,13 @@ Set the length of each segment of the TX-ONLY > packets:: >=20 > Where x[,y]* represents a CSV list of values, without white space. >=20 > +set txsplit > +~~~~~~~~~~~ > + > +Set the length of each segment of the TX packets, applicable for TX-ONLY > and CSUM forwarding modes:: > + > + testpmd> set txsplit (off|on|rand) > + > set corelist > ~~~~~~~~~~~~ >=20 > -- > 1.8.5.3 Description of "set txsplit" does not look correct. Could you fix it? It would be nice to describe the three different options (off, on, rand) as= well. Thanks, Pablo