From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] distributor: fix compilation on icc 2015
Date: Fri, 27 Nov 2015 10:39:00 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C8603BC@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <3492141.puSqUxxpuF@xps13>
Hi Thomas,
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, November 27, 2015 10:10 AM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org; Qiu, Michael
> Subject: Re: [dpdk-dev] [PATCH] distributor: fix compilation on icc 2015
>
> 2015-11-27 09:49, Pablo de Lara:
> > Fix following error on icc 2015:
> >
> > CC main.o
> > /tmp/dpdk-tmp3/examples/distributor/main.c(338): error #167:
> > argument of type "struct rte_mbuf *" is incompatible with
> > parameter of type "const char *"
> > _mm_prefetch(bufs[0], 0);
> >
> > Fixes: 07db4a97 ("examples/distributor: new sample app")
> >
> > Reported-by: Yongjie Gu <yongjiex.gu@intel.com>
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
> Hi Pablo,
>
> It is the same patch as the first one of Michael which fails with clang:
> http://dpdk.org/ml/archives/dev/2015-November/028929.html
> He has sent a second one without "const".
Oh yes, didn't see it, sorry about that.
Actually, it is strange that clang complains with const,
but not in virtio_rxtx_simple.c, where we use (const void *) in _mm_prefetch.
So, NACK to this patch and I will ack the other one.
prev parent reply other threads:[~2015-11-27 10:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 9:49 Pablo de Lara
2015-11-27 10:10 ` Thomas Monjalon
2015-11-27 10:39 ` De Lara Guarch, Pablo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8973C8603BC@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).