From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pablo.de.lara.guarch@intel.com>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 5E8C55424
 for <dev@dpdk.org>; Fri, 27 Nov 2015 11:39:09 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga102.fm.intel.com with ESMTP; 27 Nov 2015 02:39:04 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.20,351,1444719600"; d="scan'208";a="695441293"
Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31])
 by orsmga003.jf.intel.com with ESMTP; 27 Nov 2015 02:39:04 -0800
Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by
 IRSMSX106.ger.corp.intel.com (163.33.3.31) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Fri, 27 Nov 2015 10:39:01 +0000
Received: from irsmsx108.ger.corp.intel.com ([169.254.11.23]) by
 IRSMSX156.ger.corp.intel.com ([169.254.3.110]) with mapi id 14.03.0248.002;
 Fri, 27 Nov 2015 10:39:01 +0000
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Thread-Topic: [dpdk-dev] [PATCH] distributor: fix compilation on icc 2015
Thread-Index: AQHRKPkMpcabC32rm0yCW6l649ladJ6vpbGAgAAHefA=
Date: Fri, 27 Nov 2015 10:39:00 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C8603BC@IRSMSX108.ger.corp.intel.com>
References: <1448617773-97621-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <3492141.puSqUxxpuF@xps13>
In-Reply-To: <3492141.puSqUxxpuF@xps13>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [163.33.239.182]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] distributor: fix compilation on icc 2015
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Nov 2015 10:39:09 -0000

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, November 27, 2015 10:10 AM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org; Qiu, Michael
> Subject: Re: [dpdk-dev] [PATCH] distributor: fix compilation on icc 2015
>=20
> 2015-11-27 09:49, Pablo de Lara:
> > Fix following error on icc 2015:
> >
> >   CC main.o
> > /tmp/dpdk-tmp3/examples/distributor/main.c(338): error #167:
> >   argument of type "struct rte_mbuf *" is incompatible with
> >   parameter of type "const char *"
> >         _mm_prefetch(bufs[0], 0);
> >
> > Fixes: 07db4a97 ("examples/distributor: new sample app")
> >
> > Reported-by: Yongjie Gu <yongjiex.gu@intel.com>
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>=20
> Hi Pablo,
>=20
> It is the same patch as the first one of Michael which fails with clang:
> 	http://dpdk.org/ml/archives/dev/2015-November/028929.html
> He has sent a second one without "const".

Oh yes, didn't see it, sorry about that.
Actually, it is strange that clang complains with const,
but not in virtio_rxtx_simple.c, where we use (const void *) in _mm_prefetc=
h.
So, NACK to this patch and I will ack the other one.