From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C488A69C8 for ; Mon, 30 Nov 2015 09:34:19 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP; 30 Nov 2015 00:34:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,364,1444719600"; d="scan'208";a="696575372" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by orsmga003.jf.intel.com with ESMTP; 30 Nov 2015 00:34:17 -0800 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.23]) by irsmsx105.ger.corp.intel.com ([169.254.7.203]) with mapi id 14.03.0248.002; Mon, 30 Nov 2015 08:34:16 +0000 From: "De Lara Guarch, Pablo" To: Yu Nemo Wenbin , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] hash: add rte_hash_set_cmp_func() function. Thread-Index: AQHRKLj6YDhUNoXxFU+uWLpSteJpb560QZvw Date: Mon, 30 Nov 2015 08:34:15 +0000 Message-ID: References: <1448590260-15382-1-git-send-email-yuwb_bjy@ctbri.com.cn> In-Reply-To: <1448590260-15382-1-git-send-email-yuwb_bjy@ctbri.com.cn> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] hash: add rte_hash_set_cmp_func() function. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Nov 2015 08:34:20 -0000 Hi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yu Nemo Wenbin > Sent: Friday, November 27, 2015 2:11 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] hash: add rte_hash_set_cmp_func() function. >=20 > Give user a chance to customize the hash key compare function. > The default rte_hash_cmp_eq function is set in the rte_hash_create > function, but these builtin ones may not be good enough, so the user > may call this to override the default one. >=20 > Signed-off-by: Yu Nemo Wenbin > --- > lib/librte_hash/rte_cuckoo_hash.c | 7 +++++-- > lib/librte_hash/rte_hash.h | 15 +++++++++++++++ > lib/librte_hash/rte_hash_version.map | 7 +++++++ > 3 files changed, 27 insertions(+), 2 deletions(-) >=20 > diff --git a/lib/librte_hash/rte_cuckoo_hash.c > b/lib/librte_hash/rte_cuckoo_hash.c > index 88f77c3..2ccb81c 100644 > --- a/lib/librte_hash/rte_cuckoo_hash.c > +++ b/lib/librte_hash/rte_cuckoo_hash.c > @@ -102,8 +102,6 @@ EAL_REGISTER_TAILQ(rte_hash_tailq) >=20 > #define LCORE_CACHE_SIZE 8 >=20 > -typedef int (*rte_hash_cmp_eq_t)(const void *key1, const void *key2, > size_t key_len); > - > struct lcore_cache { > unsigned len; /**< Cache len */ > void *objs[LCORE_CACHE_SIZE]; /**< Cache objects */ > @@ -187,6 +185,11 @@ rte_hash_find_existing(const char *name) > return h; > } >=20 > +void rte_hash_set_cmp_func(struct rte_hash *h, rte_hash_cmp_eq_t > func) > +{ > + h->rte_hash_cmp_eq =3D func; > +} > + > struct rte_hash * > rte_hash_create(const struct rte_hash_parameters *params) > { > diff --git a/lib/librte_hash/rte_hash.h b/lib/librte_hash/rte_hash.h > index b678766..dfca5ef 100644 > --- a/lib/librte_hash/rte_hash.h > +++ b/lib/librte_hash/rte_hash.h > @@ -66,6 +66,9 @@ typedef uint32_t hash_sig_t; > typedef uint32_t (*rte_hash_function)(const void *key, uint32_t key_len, > uint32_t init_val); >=20 > +/** Type of function used to compare the hash key. */ > +typedef int (*rte_hash_cmp_eq_t)(const void *key1, const void *key2, > size_t key_len); > + > /** > * Parameters used when creating the hash table. > */ > @@ -104,6 +107,18 @@ struct rte_hash * > rte_hash_create(const struct rte_hash_parameters *params); >=20 > /** > + * Set the rte_hash_set_cmp_func. > + * Set a new hash compare function other than the default one. > + * > + * @note Function pointer does not work with multi-process, so don't use > it > + * in multi-process mode. > + * > + * @param h > + * Hash table to reset > + */ > +void rte_hash_set_cmp_func(struct rte_hash *h, rte_hash_cmp_eq_t > func); > + > +/** > * Find an existing hash table object and return a pointer to it. > * > * @param name > diff --git a/lib/librte_hash/rte_hash_version.map > b/lib/librte_hash/rte_hash_version.map > index 906c8ad..1aa94f9 100644 > --- a/lib/librte_hash/rte_hash_version.map > +++ b/lib/librte_hash/rte_hash_version.map > @@ -32,3 +32,10 @@ DPDK_2.1 { > rte_hash_reset; >=20 > } DPDK_2.0; > + > +DPDK_2.2 { > + global: > + > + rte_hash_set_cmp_func; > + > +} DPDK_2.1; > -- > 1.9.1 Acked-by: Pablo de Lara Although, you needed to send this as a v2 (or v3?)!