From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Yu Nemo Wenbin <yuwb_bjy@ctbri.com.cn>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] hash: add rte_hash_set_cmp_func() function to DPDK_2.2.
Date: Wed, 2 Dec 2015 08:26:36 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C863846@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1449022747-1056-1-git-send-email-yuwb_bjy@ctbri.com.cn>
Hi,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yu Nemo Wenbin
> Sent: Wednesday, December 02, 2015 2:19 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] hash: add rte_hash_set_cmp_func() function
> to DPDK_2.2.
>
> Give user a chance to customize the hash key compare function.
> The default rte_hash_cmp_eq function is set in the rte_hash_create
> function, but these builtin ones may not be good enough, so the user
> may call this to override the default one.
>
> Signed-off-by: Yu Nemo Wenbin <yuwb_bjy@ctbri.com.cn>
Why did you send this patch again? I see that the only thing you changed was the title,
and you don't need to include "to DPDK_2.2" in there. The only comment I had is that
you should have included versioning of the patch ("PATCH v2 or v3").
Thanks,
Pablo
prev parent reply other threads:[~2015-12-02 8:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 2:19 Yu Nemo Wenbin
2015-12-02 8:26 ` De Lara Guarch, Pablo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8973C863846@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=yuwb_bjy@ctbri.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).